Skip to content

provinces(): Fix type hinting, clean code, remove thailand_provinces_th.txt #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2020
Merged

provinces(): Fix type hinting, clean code, remove thailand_provinces_th.txt #466

merged 2 commits into from
Aug 16, 2020

Conversation

@bact
Copy link
Member

@bact bact commented Aug 13, 2020 •
edited
Loading

  • Fix type hinting
  • Remove thailand_provinces_th.txt file as the information there is duplicated with its .csv counterpart
  • Some code cleaning

Will resolve #467

@pep8speaks
Copy link

pep8speaks commented Aug 13, 2020 •
edited
Loading

Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-13 20:37:50 UTC

@bact bact requested a review from wannaphong August 13, 2020 20:34
@bact bact mentioned this pull request Aug 13, 2020
Merged
@bact bact added the enhancement enhance functionalities label Aug 13, 2020
@bact bact added this to the 2.3 milestone Aug 13, 2020
@bact bact changed the title Fix type hinting, clean code, remove thailand_provinces_th.txt provinces(): Fix type hinting, clean code, remove thailand_provinces_th.txt Aug 13, 2020
@coveralls
Copy link

coveralls commented Aug 13, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 95.053% when pulling 8b4beac on Add-provinces into 313aa92 on dev.

@bact bact requested a review from p16i August 14, 2020 09:11
@bact bact merged commit 2a853fa into dev Aug 16, 2020
@bact bact deleted the Add-provinces branch August 20, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wannaphong wannaphong wannaphong approved these changes

@p16i p16i Awaiting requested review from p16i

Assignees

No one assigned

Labels

enhancement enhance functionalities

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

corpus.common.provinces() with details option

4 participants

@bact @pep8speaks @coveralls @wannaphong