Skip to content

Fixing and enhancing text normalization funcitons #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 8, 2020
Merged

Fixing and enhancing text normalization funcitons #389

merged 11 commits into from
May 8, 2020

Conversation

@bact
Copy link
Member

@bact bact commented May 6, 2020 •
edited
Loading

@bact
- Remove repetitive tonemarks
f2a3ab3 
- Remove "phantom chars"
@pep8speaks
Copy link

pep8speaks commented May 6, 2020 •
edited
Loading

Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-08 08:32:37 UTC

@bact bact added the bug bugs in the library label May 6, 2020
@bact bact added this to the 2.2 milestone May 6, 2020
@bact bact requested a review from wannaphong May 6, 2020 18:32
@bact bact changed the title Fix: normalize() not remove repetitive tonemarks Fix: normalize() will now remove tone marks repetition May 6, 2020
@bact bact mentioned this pull request May 6, 2020
Open
@coveralls
Copy link

coveralls commented May 6, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 90.787% when pulling 0be2ea6 on feature-normalize into d1475c2 on dev.

@wannaphong
Copy link
Member

wannaphong commented May 7, 2020

I add docs. It's OK. 👍

p16i
p16i reviewed May 8, 2020
View reviewed changes
@bact bact changed the title Fix: normalize() will now remove tone marks repetition Fixing and enhancing text normalization funcitons May 8, 2020
@bact bact merged commit 4bca234 into dev May 8, 2020
@bact bact mentioned this pull request May 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p16i p16i p16i left review comments

@wannaphong wannaphong wannaphong approved these changes

Assignees

No one assigned

Labels

bug bugs in the library

Projects

None yet

Milestone

2.2

Development

Successfully merging this pull request may close these issues.

Text normalization not working in some cases Add a more advanced normalize function Add a function to remove zero-width characters

6 participants

@bact @pep8speaks @coveralls @wannaphong @p16i