Skip to content

Conversation

zkan
Copy link

@zkan zkan commented Oct 7, 2018

Changes proposed in this pull request:

  • Move test folder out of main lib and rename it to tests.
  • Fix Flake8 errors in the tests (only).
  • Rename example folder to examples.
  • Make the CircleCI configuration work and run Flake8 and unit tests for us.

The folder structure is inspired by https://github.com/stripe/stripe-python. I think it'd be great if we follow what people in a big company do.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.4%) to 53.451% when pulling ecdca79 on zkan:move_test_folder into 63f9032 on PyThaiNLP:dev.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.4%) to 53.451% when pulling ecdca79 on zkan:move_test_folder into 63f9032 on PyThaiNLP:dev.

@wannaphong wannaphong added this to the 1.8 milestone Oct 8, 2018
@wannaphong wannaphong merged commit aaf027a into PyThaiNLP:dev Oct 8, 2018
@zkan zkan deleted the move_test_folder branch October 8, 2018 14:42
@wannaphong wannaphong mentioned this pull request Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants