Convert mcs_label from bytes to string if defined #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it is defined, the mcs_label on nodes are bytes: # python3 Python 3.6.8 (default, Dec 5 2019, 15:45:45) [GCC 8.3.1 20191121 (Red Hat 8.3.1-5)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import pyslurm >>> pyslurm.node().get()['cn1']['mcs_label'] b'label' >>> type(pyslurm.node().get()['cn1']['mcs_label']) <class 'bytes'> With this commit, it is converted to a unicode string for easier handling by consumer.
giovtorres
approved these changes
Nov 25, 2021
|
My pleasure, thank you @giovtorres for merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it is defined, the mcs_label on nodes are bytes:
With this commit, it is converted to a unicode string for easier handling by consumer.
Seen with Slurm 20.02.2 and custom version of pyslurm, but patch applies on current main branch.