F821 with mypy 0.730 error code ignores

[The-Compiler]

The new mypy 0.730 release allows more specific # type: ignore annotations such as:

        assert value is not configutils.UNSET  # type: ignore[comparison-overlap]

However, this causes pyflakes to complain:

qutebrowser/config/websettings.py:96: undefined name 'ignore'
qutebrowser/config/websettings.py:96: undefined name 'comparison'
qutebrowser/config/websettings.py:96: undefined name 'overlap'

[asottile]

have you tried against master?

[asottile]

#455 already fixed this

[The-Compiler]

Whoops - just after opening the issue I took a look at the code and found fa92556 as well.

Indeed works fine on master, sorry for the noise!

[vitawasalreadytaken]

Hi, I second @Artimi in #373 (comment) – please, please, please, release a version 🥺. This has been fixed for three months but nobody can benefit from it unless they install a non-released version from Git which is (rightly) considered bad practice. Thank you so much!

[asottile]

we'll release when we're ready 🙏 -- commenting "please release" is one of the least productive (and borderline rude) things you can do on an open source project ;)

[vitawasalreadytaken]

'Borderline rude'? Good heavens, no, that's not at all what I intended. I am sorry if it came out that way. As for 'least productive',... as a user, I just wanted to help by providing feedback that this feature is sought after. Do as you will with that feedback, but it saddens me to hear you consider it unproductive.

Surely we would call submitting a PR a 'productive' thing. But until there is a release all that was produced by contributors (~17 PRs since 2.1.1) has little usable value.

[asottile]

Sorry, it might not be what you intended but it falls into the same category as comments that are like "is this project dead?" "when will someone fix this bug?" etc. etc. -- please remember that the people working on most open source projects are doing it out of their own good will and free time (and free time). A comment asking for a release is not going to get you a release any faster -- trust us we already know there are unreleased changes on master which will be released eventually!

If you want, you can always install from git until a true release is made (pip install git+https://github.com/pycqa/pyflakes)

[vitawasalreadytaken]

Thank you for your good will and free time. Please don't waste it any longer on this pointless conversation.

If someone else finds this thread, make sure you pin your dependencies and don't install from Git blindly. pip install git+https://github.com/pycqa/pyflakes.git@SOME_COMMIT. For example, to install the latest master as of the time of this comment, pip install git+https://github.com/pycqa/pyflakes.git@1911c203a13826d2eb03d582d60874b91e36f4fc.