Hotfix issue 153 #161
Merged
Hotfix issue 153 #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
hotfix_issue153
branch
2 times, most recently
from
455147d to
856adfb
Compare
neutrinoceros
force-pushed
the
hotfix_issue153
branch
from
856adfb to
6503ba7
Compare
cooperlees
approved these changes
Mar 8, 2021
Collaborator
cooperlees
left a comment
cooperlees
left a comment
There was a problem hiding this comment.
Thanks! LGTM, This handles the condition and stops us crashing. I can't see a better way to do this. If anyone else can we can forward fix!
Contributor
Author
|
Thank you for merging ! |
Collaborator
|
Yeah, I have it all automated apart from changes in README.rst - So releasing is easy here. Just need to not let it sit so long so we ship more with less change. |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #153
This is my very first experience with
astand I'll admit I don't really know what I'm doing. I added a test based on the issue's description, checked that it failed with the current state of the code base as reported, and applied a minimal patch to make it pass without breaking any other test.