Fix missing images in Radar Basics #129
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
|
Unfortunately the mp4 of the radar energy emission is now being rendered as a static image: https://projectpythia.org/radar-cookbook/_preview/129/notebooks/radar-basics/radar-basics.html#emitted-energy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125
I think the images are missing because of issues with how JupyterBook handles paths, e.g. https://jupyterbook.org/en/stable/advanced/html.html#use-raw-html-in-markdown
This PR replaces the HTML image tags with pure Markdown, which plays better with JupyterBook. We just lose the ability have video controls on the animation.