Drop in Unidata netcdf+CF notebook for core/data-formats #36
Conversation
|
🚀 📚 Preview for git commit SHA: 9b5e13d at: https://607f4bca71ba8900a2044bbd--pythia-foundations.netlify.app |
| @@ -0,0 +1,901 @@ | |||
| { | |||
There was a problem hiding this comment.
This all looks fantastic - I think it would be good to show an example of cf-xarray and why it it can be useful to follow this/how it can make operations more general when you can use this metadata
Reply via ReviewNB
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
🚀 📚 Preview for git commit SHA: 4945a75 at: https://60c248c97a039e125de11429--pythia-foundations.netlify.app |
ktyle
requested review from
a team,
dopplershift and
jukent
and removed request for
a team
|
This has been fit to the template and is ready for review. |
core/data-formats/netcdf-cf.ipynb
Outdated
| " :comment = \"\" ;\n", | ||
| "}\n", | ||
| "```\n", | ||
| "We can also add attributes to this variable to define metadata. The CF conventions require a `units` attribute to be set for all variables that represent a dimensional quantity. The value of this attribute needs to be parsable by the UDUNITS library. Here we set it to a value of `'Kelvin'`. We also set the standard (optional) attributes of `long_name` and `standard_name`. The former contains a longer description of the variable, while the latter comes from a controlled vocabulary in the CF conventions. This allows users of data to understand, in a standard fashion, what a variable represents. If we had missing values, we could also set the `missing_value` attribute to an appropriate value." |
There was a problem hiding this comment.
Maybe we should say more about the UDUNITS library - a link to it at least.
core/data-formats/netcdf-cf.ipynb
Outdated
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "## Summary" |
|
@ktyle just checking in to see if this is still doable for Wednesday. Thanks! |
|
Should we defer to @dcamron to incorporate the items that have arisen from the reviews? |
|
After discussion on the Zoom call, I will take care of incorporating the suggested edits (including my own) and will follow-up once it's ready for another review. |
|
I'm in transit to Minneapolis this afternoon, but I will attend to @jukent 's review comments and push for final review by midnight this evening. |
|
I have pushed the notebook with content that responds to @jukent 's suggestions, as well as some other edits. The "Summary" and "What's Next" sections could probably be improved, but better than nothing. Git reported that in addition to the netcdf-cf.ipynb file, two other files had changed:
I'm not sure how best to resolve those latter two files ... the netcdf-cf notebook is the only relevant change. I'm hoping someone else can take care of resolving and ultimately merging. Other than that, this is ready for another review. |
|
🚀 📚 Preview for git commit SHA: 7333ffe at: https://60c93c95a47d1e5dfc6f49bc--pythia-foundations.netlify.app |
6 participants
This is a drop-in of this notebook from Unidata's workshop materials with exercises and branding removed. Otherwise has been mostly content-unmodified.
Notes: