Skip to content

Add new matplotlib notebook #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

Add new matplotlib notebook #170

wants to merge 20 commits into from

Conversation

@mgrover1
Copy link
Contributor

Another section of matplotlib content, originally put together by @anissa111, with some additional narration/theme matching.

Towards #167

@mgrover1 mgrover1 requested a review from a team as a code owner October 28, 2021 19:29
@mgrover1 mgrover1 requested review from dopplershift and michaelavs and removed request for a team October 28, 2021 19:29
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Oct 28, 2021 •
edited
Loading

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: 56dc82f
✅ Deployment Preview URL: https://62155f31e917c82d239700c1--pythia-foundations.netlify.app

dopplershift
dopplershift reviewed Oct 28, 2021
View reviewed changes
@jukent jukent added the content Content related issue label Nov 8, 2021
@mgrover1
Copy link
Contributor Author

mgrover1 commented Dec 2, 2021

@michaelavs could you take a look at this soon?

@mgrover1 mgrover1 requested a review from dopplershift December 2, 2021 16:13
@brian-rose
Copy link
Member

Hi @mgrover1 , I added a bunch of comments on reviewnb.

I'm glad I read through this because I learned about subplot_mosaic for the first time! That's a feature I've been waiting for.

@michaelavs
Copy link

michaelavs commented Dec 2, 2021 •
edited
Loading

Hi @mgrover1 ,
Sorry for any delays caused by me, I didn't realize I was listed as a reviewer on this PR!

I went through on reviewnb and added a couple comments, but I think things look good overall!

@brian-rose
Copy link
Member

@mgrover1 I can't find my comments anywhere, nor those from @michaelavs. Seems that ReviewNB may have eaten them for breakfast. I will just start over and do a new review.

@brian-rose
Copy link
Member

@mgrover1 I can't find my comments anywhere, nor those from @michaelavs. Seems that ReviewNB may have eaten them for breakfast. I will just start over and do a new review.

Actually now I CAN see our comments at https://app.reviewnb.com/ProjectPythia/pythia-foundations/blob/advanced_matplotlib/core/matplotlib/additional-topics2.ipynb/
I'm not sure what's going on, or why the comments never migrated over to this GitHub discussion.

@brian-rose brian-rose mentioned this pull request Feb 17, 2022
Closed
@jukent
Copy link
Contributor

jukent commented Feb 18, 2022

I'm gonna see what I can do to get this content merge-able

@jukent jukent mentioned this pull request Feb 18, 2022
Merged
@jukent jukent closed this in #230 Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelavs michaelavs Awaiting requested review from michaelavs michaelavs is a code owner automatically assigned from ProjectPythia/education

@dopplershift dopplershift Awaiting requested review from dopplershift

Assignees

No one assigned

Labels

content Content related issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mgrover1 @brian-rose @michaelavs @jukent @dopplershift