dropdown gallery changes #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
Contributor
Author
|
Refactoring both galleries could be another effort. Might not be worth it with possible Jupyterbook2 MyST migration? |
Contributor
kafitzgerald
left a comment
kafitzgerald
left a comment
There was a problem hiding this comment.
Was checking this out and it looks like the default color for links before they've been clicked now is really similar to the background.
Contributor
Author
|
I think that is unrelated to these changes. I should probably correct that in the theme repo instead of here. |
kafitzgerald
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the gallery filtering, the dark theme on the resource gallery (only accessible if theme is changed on about page or similar and then you navigate to foundations page), and does CSS changes to dropdown buttons.
Closes #419