-
Notifications
You must be signed in to change notification settings - Fork 24
Fix resource gallery submission workflow #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…json needs the former
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
| affiliation=item.get('affiliation'), | ||
| affiliation_url=item.get('affiliation_url'), | ||
| affiliation=item.get('institution'), | ||
| affiliation_url=item.get('institution_url'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A thought: should we update the form template and card text to all use "Affiliation" regardless? It seems more broadly applicable than "Institution" and is in-line with expected fields in eg CITATION.cff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree! We can do that in conjunction with this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see ProjectPythia/.github/PR#63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and also the gallery_generator.py and resource_gallery.yaml files here for "institution" to "affiliation" changes
|
Note to reviewers: This PR should be complete; and input submission validation should likely be running successfully. I am not 100% sure because when I bypassed branch protections and merged a prior PR into the main (FYI: later reverted) to see the things because testing this locally is quite hard and testing without merging into main is impossible, there was a serialization error at the final line of After that, this PR uses To test similar things locally, I used a sample github event payload file that had an issue creation event in it but could not replicate this serialization issue. I suggest that we merge this into main and see how it behaves, if things still don't get validated, we can follow up with an additional PR. |
|
Agreed! Thanks Orhan. |
Closes #369
This PR addresses the needs due to version changes in pydantic as suggested in the pydantic Migration Guide:
__post_init_post_parse__()and move its functionality into_get_inputs()model_dump_json()instead of deprecateddict()gallery_generator.py,resource_gallery.yaml, andcollect-user-submission.pyfiles. This change also needed the ProjectPythia/.github/PR#63Note to reviewers: See