Skip to content

Conversation

@kmpaul
Copy link
Collaborator

@kmpaul kmpaul commented Jan 3, 2022

This attempts to update the portal to use version 2021.12.7 of the Sphinx Pythia Theme. I believe this addresses some of the issues noted in previous discussions. Please take a look and tell me what you think!

@kmpaul kmpaul requested review from a team as code owners January 3, 2022 19:56
@kmpaul kmpaul requested review from clyne, dcamron and jukent and removed request for a team January 3, 2022 19:56
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2022

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: 5394306
✅ Deployment Preview URL: https://61df24e328128a21c335d99a--projectpythia-org.netlify.app

@kmpaul kmpaul closed this Jan 3, 2022
@kmpaul kmpaul reopened this Jan 3, 2022
@dcamron
Copy link
Contributor

dcamron commented Jan 6, 2022

FYI at 2560x1440, Firefox 95.0.2, macos 12.1, the "single-page" background colors don't extend beyond the content column,

image

if that was intended. Current https://projectpythia.org/ extends these fully.

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jan 6, 2022

@dcamron: Hmm. I suspect that is because of some layout changes I had to make to get features from the base themes to work in this theme. I'll look into it and see if I can find a fix.

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jan 11, 2022

@dcamron: Strangely, this appears to be coming from a base theme (PyData Sphinx Theme, I think), which is where Bootstrap is imported. I can verify that the changes made to the new theme result in the use of Bootstrap container-xl divisions, rather than container-fluid divisions. And container-xl has a max-width of 1400px. So, that's the problem.

I'll see if I can fix this in the theme.

@kmpaul kmpaul closed this Jan 11, 2022
@kmpaul kmpaul reopened this Jan 11, 2022
@kmpaul
Copy link
Collaborator Author

kmpaul commented Jan 11, 2022

Ok. I think the latest release of the theme fixes the high-res display issues.

@kmpaul kmpaul marked this pull request as draft January 11, 2022 18:53
@kmpaul kmpaul requested review from clyne and jukent January 11, 2022 19:51
@kmpaul kmpaul marked this pull request as ready for review January 11, 2022 19:51
@kmpaul
Copy link
Collaborator Author

kmpaul commented Jan 11, 2022

I think these changes implement the features we discussed in the last meeting. Let me know what you all think!

@clyne
Copy link
Contributor

clyne commented Jan 12, 2022

@kmpaul when I try to look at the deployment preview the link is broken....Any other way to see it?

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jan 12, 2022

The link works for me.

@kmpaul kmpaul closed this Jan 12, 2022
@kmpaul kmpaul reopened this Jan 12, 2022
@jukent
Copy link
Contributor

jukent commented Jan 12, 2022

@kmpaul when I try to look at the deployment preview the link is broken....Any other way to see it?

@clyne I think this is the link:

Deployment Preview URL: https://61df24e328128a21c335d99a--projectpythia-org.netlify.app

It is a little confusing because at the bottom of the page it also says, "This branch has not been deployed."

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jan 12, 2022

@clyne: Also, if you are getting a "Safety Warning" when you click on the link, that is just because of the way netlify works. I've received that before, and it's just an artifact of using a special service to deploy the website.

You can safely say "ignore" when you get the Safety Warning and see the site preview.

@clyne
Copy link
Contributor

clyne commented Jan 12, 2022

@clyne: Also, if you are getting a "Safety Warning" when you click on the link, that is just because of the way netlify works. I've received that before, and it's just an artifact of using a special service to deploy the website.

You can safely say "ignore" when you get the Safety Warning and see the site preview.

Seems to work now. No telling what I was doing wrong. Probably operator error. Thanks for the help.

Copy link
Contributor

@clyne clyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Great work.

@kmpaul kmpaul merged commit d24ed73 into ProjectPythia:main Jan 12, 2022
@kmpaul kmpaul deleted the updated-theme branch January 12, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants