Skip to content

Conversation

@clyne
Copy link
Contributor

@clyne clyne commented Jun 15, 2021

A few minor corrections to the contributor's guide.

@clyne clyne requested review from a team, brian-rose and kmpaul and removed request for a team June 15, 2021 19:34
@clyne clyne requested a review from a team as a code owner June 15, 2021 19:34
> **Note:**
> Repository-specific contributor's
> information can always be accessed by navigating your web browser
> to the appropriate Project Pythia GitHub repository,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe pedantic quibble, but isn't the markdown > notation supposed to be reserved for block quotes? E.g. https://guides.github.com/pdfs/markdown-cheatsheet-online.pdf

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could instead wrap this text in an HTML admonition, like

<div class="alert alert-block alert-info">
    <b>Note:</b> 
Repository-specific contributor's information can always be accessed by navigating your web browser to the appropriate Project Pythia GitHub repository... </div>

@clyne clyne requested a review from brian-rose June 15, 2021 20:52
Copy link
Collaborator

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kmpaul kmpaul merged commit 1220a6e into main Jun 16, 2021
@andersy005 andersy005 deleted the contrib_guide_revisions branch June 28, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants