Skip to content

restrict payload file deletion when workflow is running #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2023
Merged

restrict payload file deletion when workflow is running #794

merged 1 commit into from
May 11, 2023

Conversation

samrooke
Copy link
Collaborator

Description

Don't allow deletion of the payload files when the workflow is still in progress.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • All tests passed locally.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@samrooke samrooke merged commit 21709f6 into develop May 11, 2023
@woodheadio woodheadio added the bug Something isn't working label May 11, 2023
@woodheadio woodheadio added this to the 0.1.16 milestone May 11, 2023
@mocsharp mocsharp deleted the samrooke/AC-2201-dont-delete-payload-when-workflow-running branch June 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@answeranand answeranand answeranand approved these changes

@mehranrashid mehranrashid mehranrashid approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.16
Development

Successfully merging this pull request may close these issues.
4 participants
@samrooke @answeranand @mehranrashid @woodheadio