Skip to content

Conversation

@MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Sep 15, 2022

This pull request intends to merge some changes made during the IHE Connectathon IAIP testing.

  • Update the series selection operator to support matching DICOM instance level metadata
  • Updated the liver tumor segmentation example to include simple filtering rules
  • Updated the text SR writer to add time zone offset from UTC, while keep content date time local
  • Updated the text SR writer to use content sequence for sections of text
  • Updated the text SR writer storage SOP class to that of basic text SR

@MMelQin MMelQin requested a review from vikashg September 28, 2022 07:08
@MMelQin MMelQin self-assigned this Sep 28, 2022
@MMelQin MMelQin added the enhancement New feature or request label Sep 28, 2022
@vikashg
Copy link
Collaborator

vikashg commented Oct 3, 2022

Everything looks good to me.

@vikashg vikashg closed this Oct 3, 2022
Copy link
Collaborator

@vikashg vikashg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding Media Storage SOP Class UID, that was really helpful @MMelQin

@MMelQin
Copy link
Collaborator Author

MMelQin commented Oct 3, 2022

Thanks for adding Media Storage SOP Class UID, that was really helpful @MMelQin

The Storage SOP Class UID attributed was changed from Comprehensive 3D to the more representative Basic Text SR in the PR.

Also, I need to reopen this to merge the PR.

@MMelQin MMelQin reopened this Oct 3, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MMelQin MMelQin merged commit fc07d80 into main Oct 3, 2022
@MMelQin MMelQin linked an issue Oct 4, 2022 that may be closed by this pull request
@MMelQin MMelQin deleted the mqin/sr_minor_correction branch March 17, 2023 20:58
SimoneBendazzoli93 pushed a commit to SimoneBendazzoli93/monai-deploy-app-sdk that referenced this pull request Jul 17, 2025
* Added support of matching instance level tags, and update liver seg

Signed-off-by: M Q <[email protected]>

* Fix Flake8 complaint

Signed-off-by: M Q <[email protected]>

* Still enable publish intermediate nii files.

Signed-off-by: M Q <[email protected]>

* Corrections per review comments

Signed-off-by: M Q <[email protected]>

* Enhance attribute settings

Signed-off-by: M Q <[email protected]>

* Fixed styling complaints

Signed-off-by: M Q <[email protected]>

* Fix MyPy complaint

Signed-off-by: M Q <[email protected]>

* Use content sequence for section of text

Signed-off-by: M Q <[email protected]>

Signed-off-by: M Q <[email protected]>
Signed-off-by: Simone Bendazzoli <[email protected]>
SimoneBendazzoli93 pushed a commit to SimoneBendazzoli93/monai-deploy-app-sdk that referenced this pull request Jul 17, 2025
* Added support of matching instance level tags, and update liver seg

Signed-off-by: M Q <[email protected]>

* Fix Flake8 complaint

Signed-off-by: M Q <[email protected]>

* Still enable publish intermediate nii files.

Signed-off-by: M Q <[email protected]>

* Corrections per review comments

Signed-off-by: M Q <[email protected]>

* Enhance attribute settings

Signed-off-by: M Q <[email protected]>

* Fixed styling complaints

Signed-off-by: M Q <[email protected]>

* Fix MyPy complaint

Signed-off-by: M Q <[email protected]>

* Use content sequence for section of text

Signed-off-by: M Q <[email protected]>

Signed-off-by: M Q <[email protected]>
Signed-off-by: Simone Bendazzoli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA] Set the time zone offset in the generated DICOM object

3 participants