-
Notifications
You must be signed in to change notification settings - Fork 62
Enhance some attributes in the text SR writer #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
|
Everything looks good to me. |
vikashg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding Media Storage SOP Class UID, that was really helpful @MMelQin
The Storage SOP Class UID attributed was changed from Comprehensive 3D to the more representative Basic Text SR in the PR. Also, I need to reopen this to merge the PR. |
|
Kudos, SonarCloud Quality Gate passed!
|
* Added support of matching instance level tags, and update liver seg Signed-off-by: M Q <[email protected]> * Fix Flake8 complaint Signed-off-by: M Q <[email protected]> * Still enable publish intermediate nii files. Signed-off-by: M Q <[email protected]> * Corrections per review comments Signed-off-by: M Q <[email protected]> * Enhance attribute settings Signed-off-by: M Q <[email protected]> * Fixed styling complaints Signed-off-by: M Q <[email protected]> * Fix MyPy complaint Signed-off-by: M Q <[email protected]> * Use content sequence for section of text Signed-off-by: M Q <[email protected]> Signed-off-by: M Q <[email protected]> Signed-off-by: Simone Bendazzoli <[email protected]>
* Added support of matching instance level tags, and update liver seg Signed-off-by: M Q <[email protected]> * Fix Flake8 complaint Signed-off-by: M Q <[email protected]> * Still enable publish intermediate nii files. Signed-off-by: M Q <[email protected]> * Corrections per review comments Signed-off-by: M Q <[email protected]> * Enhance attribute settings Signed-off-by: M Q <[email protected]> * Fixed styling complaints Signed-off-by: M Q <[email protected]> * Fix MyPy complaint Signed-off-by: M Q <[email protected]> * Use content sequence for section of text Signed-off-by: M Q <[email protected]> Signed-off-by: M Q <[email protected]> Signed-off-by: Simone Bendazzoli <[email protected]>








This pull request intends to merge some changes made during the IHE Connectathon IAIP testing.