Skip to content

Fix lazy ignored in SpatialPadd #7316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Fix lazy ignored in SpatialPadd #7316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3611f07
fix #7315
KumoLiu Dec 13, 2023
95f1d2e
minor fix
KumoLiu Dec 13, 2023
f12b7f6
Merge branch 'dev' into lazy
KumoLiu Dec 14, 2023
a92d051
Update monai/transforms/croppad/dictionary.py
KumoLiu Dec 18, 2023
4766123
Update monai/transforms/croppad/dictionary.py
KumoLiu Dec 18, 2023
bb781de
Update monai/transforms/croppad/dictionary.py
KumoLiu Dec 18, 2023
45fd8f7
Merge branch 'dev' into lazy
KumoLiu Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions monai/transforms/croppad/dictionary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,8 @@ def __init__(
note that `np.pad` treats channel dimension as the first dimension.

"""
LazyTransform.__init__(self, lazy)
padder = SpatialPad(spatial_size, method, lazy=lazy, **kwargs)
Padd.__init__(self, keys, padder=padder, mode=mode, allow_missing_keys=allow_missing_keys)
Padd.__init__(self, keys, padder=padder, mode=mode, allow_missing_keys=allow_missing_keys, lazy=lazy)


class BorderPadd(Padd):
Expand Down Expand Up @@ -274,9 +273,8 @@ def __init__(
note that `np.pad` treats channel dimension as the first dimension.

"""
LazyTransform.__init__(self, lazy)
padder = BorderPad(spatial_border=spatial_border, lazy=lazy, **kwargs)
Padd.__init__(self, keys, padder=padder, mode=mode, allow_missing_keys=allow_missing_keys)
Padd.__init__(self, keys, padder=padder, mode=mode, allow_missing_keys=allow_missing_keys, lazy=lazy)


class DivisiblePadd(Padd):
Expand Down Expand Up @@ -324,9 +322,8 @@ def __init__(
See also :py:class:`monai.transforms.SpatialPad`

"""
LazyTransform.__init__(self, lazy)
padder = DivisiblePad(k=k, method=method, lazy=lazy, **kwargs)
Padd.__init__(self, keys, padder=padder, mode=mode, allow_missing_keys=allow_missing_keys)
Padd.__init__(self, keys, padder=padder, mode=mode, allow_missing_keys=allow_missing_keys, lazy=lazy)


class Cropd(MapTransform, InvertibleTransform, LazyTransform):
Expand Down
3 changes: 3 additions & 0 deletions tests/padders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@ def pad_test_pending_ops(self, input_param, input_shape):
# TODO: mode="bilinear" may report error
overrides = {"mode": "nearest", "padding_mode": mode[1], "align_corners": False}
result = apply_pending(pending_result, overrides=overrides)[0]
# lazy in constructor
pad_fn_lazy = self.Padder(mode=mode[0], lazy=True, **input_param)
self.assertTrue(pad_fn_lazy.lazy)
# compare
assert_allclose(result, expected, rtol=1e-5)
if isinstance(result, MetaTensor) and not isinstance(pad_fn, MapTransform):
Expand Down