Fix set_timesteps #163
Fix set_timesteps #163
Conversation
…ger than num_train_timesteps Signed-off-by: Walter Hugo Lopez Pinaya <[email protected]>
Signed-off-by: Walter Hugo Lopez Pinaya <[email protected]>
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
Looks fine to me, I don't see what the issue is with num_inference_step being a power of 3 but it's something you encountered clearly.
| step_ratio = self.num_train_timesteps // self.num_inference_steps | ||
| # creates integer timesteps by multiplying by ratio | ||
| # casting to int to avoid issues when num_inference_step is power of 3 | ||
| timesteps = (np.arange(0, num_inference_steps) * step_ratio).round()[::-1].copy().astype(np.int64) |
There was a problem hiding this comment.
I don't think copy is needed here, the array is fresh and round should also return a fresh one.
There was a problem hiding this comment.
Good point, again it was from the base implementation (huggingface/diffusers#724), but I think here it is safe to remove (for example PNDM already does not use it)
Thanks, Eric! The "power of 3" is one point that we found in the reference code and we kept to avoid problems (discussed here huggingface/diffusers#466) |
Signed-off-by: Walter Hugo Lopez Pinaya <[email protected]>
Warvito
deleted the
162-wrong-number-of-timesteps-when-num_inference_steps-is-not-a-divisor-of-num_train_timesteps
branch
Fix #162
Signed-off-by: Walter Hugo Lopez Pinaya [email protected]