Skip to content

added support for formSheet and pageSheet presentation style #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added support for formSheet and pageSheet presentation style #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57f2c0e
added support for formSheet and pageSheet presentation style
nemophrost Jun 29, 2017
d7e5a8f
updated README
nemophrost Jun 29, 2017
87ba49d
Merge branch 'master' into presentation-style
nemophrost Nov 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion RCTBrowser.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,13 @@ @implementation RCTBrowser

[nav.navigationBar setTitleTextAttributes:
@{NSForegroundColorAttributeName:color}];
}
} else if ([key isEqualToString:@"presentationStyle"]) {
if ([obj isEqual: @"formSheet"]) {
nav.modalPresentationStyle = UIModalPresentationFormSheet;
} else if ([obj isEqual: @"pageSheet"]) {
nav.modalPresentationStyle = UIModalPresentationPageSheet;
}
}
}];

dispatch_async(dispatch_get_main_queue(), ^{
Expand Down
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,17 @@ Browser.open('https://google.com/', {
titleTintColor: processColor('#d64bbd'),
barTintColor: processColor('#d64bbd')
});

// To change the presentation style from the default, you can additionally pass in:
Browser.open('https://google.com/', {
presentationStyle: 'formSheet' // can be one of [undefined, 'pageSheet', 'formSheet']
});
// For differences, see:
// https://developer.apple.com/library/content/featuredarticles/ViewControllerPGforiPhoneOS/PresentingaViewController.html
```



[Descriptions of options and their defaults](https://github.com/TimOliver/TOWebViewController/blob/master/TOWebViewController/TOWebViewController.h)

### TODOs
Expand Down