Skip to content

Update Description to reflect that PowerShell is for more than scripting #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2021
Merged

Update Description to reflect that PowerShell is for more than scripting #3340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"version": "2021.4.2",
"preview": true,
"publisher": "ms-vscode",
"description": "(Preview) Develop PowerShell scripts in Visual Studio Code!",
"description": "(Preview) Develop PowerShell modules, commands and scripts in Visual Studio Code!",
"engines": {
"vscode": "^1.52.0"
},
Expand Down
2 changes: 1 addition & 1 deletion tools/ReleaseTools.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ function Update-Version {
# TODO: Maybe cleanup the replacement logic.
switch ($RepositoryName) {
"vscode-powershell" {
$d = "Develop PowerShell scripts in Visual Studio Code!"
$d = "Develop PowerShell modules, commands and scripts in Visual Studio Code!"
Copy link
Member

@andyleejordan andyleejordan May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this 😁

if ($Version.PreReleaseLabel) {
$name = "powershell-preview"
$displayName = "PowerShell Preview"
Expand Down
2 changes: 1 addition & 1 deletion tools/postReleaseScripts/updateAzureDataStudio.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ function NewPowerShellExtensionEntry
extensionId = '35'
extensionName = 'powershell'
displayName = 'PowerShell'
shortDescription = 'Develop PowerShell scripts in Azure Data Studio'
shortDescription = 'Develop PowerShell modules, commands and scripts in Azure Data Studio'
publisher = [ordered]@{
displayName = 'Microsoft'
publisherId = 'Microsoft'
Expand Down
4 changes: 2 additions & 2 deletions vscode-powershell.build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,12 @@ task UpdatePackageJson {
if ($script:IsPreviewExtension) {
$script:PackageJson.name = "powershell-preview"
$script:PackageJson.displayName = "PowerShell Preview"
$script:PackageJson.description = "(Preview) Develop PowerShell scripts in Visual Studio Code!"
$script:PackageJson.description = "(Preview) Develop PowerShell modules, commands and scripts in Visual Studio Code!"
Copy link
Member

@andyleejordan andyleejordan May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg what is this script doing. @rjmholt?!

$script:PackageJson.preview = $true
} else {
$script:PackageJson.name = "powershell"
$script:PackageJson.displayName = "PowerShell"
$script:PackageJson.description = "Develop PowerShell scripts in Visual Studio Code!"
$script:PackageJson.description = "Develop PowerShell modules, commands and scripts in Visual Studio Code!"
$script:PackageJson.preview = $false
}

Expand Down