Skip to content

Conversation

@andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Jan 7, 2022

These tests actually did not require the language server nor the service provider, we just had to manually initialize the extension service itself. Resolves #1444.

@andyleejordan
Copy link
Member Author

Yay, an easy one!

@andyleejordan andyleejordan force-pushed the andschwa/extension-command-tests branch from 1b2ac7f to 2c60291 Compare January 7, 2022 00:41
These tests actually did not require the language server nor the service
provider, we just had to manually initialize the extension service
itself.
@andyleejordan andyleejordan force-pushed the andschwa/extension-command-tests branch from 2c60291 to 17b9c45 Compare January 7, 2022 19:01
@andyleejordan andyleejordan force-pushed the andschwa/extension-command-tests branch from 419d4d4 to 3bf231e Compare January 7, 2022 19:17
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit 798fc8d into master Jan 7, 2022
@andyleejordan andyleejordan deleted the andschwa/extension-command-tests branch January 7, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Test Issue-Bug A bug to squash.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Fix tests in Extensions/ExtensionCommandTests.cs

4 participants