Add magic value formatting for variable booleans #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeeminglyScience
approved these changes
Nov 26, 2021
src/PowerShellEditorServices/Services/DebugAdapter/Debugging/VariableDetails.cs
Outdated
Show resolved
Hide resolved
Member
|
I really like this, but I want to get the debug service tests re-enabled first. At that point, this may break (but the break will be "update tests' expectations." Sound good? I'm making progress on the tests! |
JustinGrote
force-pushed
the
JustinGrote/fixVariablePresentation
branch
from
2fb5a50 to
5f0282c
Compare
Collaborator
Author
|
@andschwa thanks for fixing the debugger, I've added related tests. |
Co-authored-by: Patrick Meinecke <[email protected]> Co-authored-by: Andy Schwartzmeyer <[email protected]>
andyleejordan
force-pushed
the
JustinGrote/fixVariablePresentation
branch
from
c3f81f2 to
3509712
Compare
andyleejordan
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes PowerShell/vscode-powershell#3703
$true and $false now highlight correctly regardless of vscode bug, and number/string type is still preserved.
