Implement Format-Hex in C# #3320

MiaRomero · 2017-03-13T19:30:03Z

Addressing issue #2730 'Rewrite Format-Hex in C#'

Documentation for Format-Hex states both the Path and LiteralPath parameters accept string arrays, though this functionality was not actually present for the cmdlet. This has been corrected so both parameters can accept and process an array of strings. If an invalid path is included in the array, a non-terminating 'FileNotFound' error will be thrown, but the remaining valid paths will be processed and output as usual.
After a discussion with @Francisco-Gamino and @joeyaiello, it was decided to make the Raw parameter No-op. Going forward all of the output will be displayed with a true representation of numbers that includes all of the bytes for its type (what the Raw parameter was formally doing). For example, [Int32]170 passed to Format-Hex would have previously displayed only "AA". Now it will display "AA 00 00 00".
Updated the InputObject parameter to accept an Int32[], in addition to all previously accepted types.
The way Format-Hex processes and displays input from the pipeline has been corrected. Previously, the output for numbers in an array or range would be combined into one as seen below:

  PS D:\GitHub\PowerShell> 1,2 | fhx


           Path:

           00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F

  00000000   01 02                                            ..

Now each number will be displayed as its own input object:

  PS D:\GitHub\PowerShell> 1,2 |fhx


           00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F

  00000000   01 00 00 00                                      ....


           00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F

  00000000   02 00 00 00                                      ....

Added a new error that states Format-Hex only supports FileSystem Provider Paths. Previously an error was thrown, but was not specific about the problem (and was displaying the wrong path).

fhx : The given path 'Cert:\CurrentUser\My\' is not supported. This command only supports the FileSystem Provider paths.
At line:1 char:1
+ fhx -path Cert:\CurrentUser\My\
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (Cert:\CurrentUser\My\:String) [Format-Hex], ArgumentException
    + FullyQualifiedErrorId : FormatHexOnlySupportsFileSystemPaths,Microsoft.PowerShell.Commands.FormatHex

Cleaned up how we are exposing the Format-Hex error messages. Removed from UtilityCommon.cs and are being accessed through UtilityCommonStrings.resx instead.
Updated and added tests for this cmdlet to validate newly implemented functionality and to be more comprehensive for original functionality.

msftclas · 2017-03-13T19:30:07Z

@MiaRomero,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

Francisco-Gamino · 2017-03-13T19:31:49Z

@SandeepSutari, @mirichmo, @daxian-dbw, @joeyaiello: Could you please take a look? Thanks.

SandeepSutari · 2017-03-13T23:23:10Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+        /// </summary>
+        /// <param name="encoding"></param>
+        /// <returns></returns>
+        private Encoding GetEncoding(string encoding)


Why is the private member not camel cased ? Unless Pascal casing is the recommended pattern for C# cmdlets, we should use camel casing

I mean method name...var name is fine

I talked to @daxian-dbw about this, and Pascal casing is the recommended pattern for the cmdlets.

SandeepSutari · 2017-03-13T23:24:22Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+            {
+                string inputObject = obj.ToString();
+                byte[] inputBytes = GetEncoding(_encoding).GetBytes(inputObject);
+                ConvertToHexidecimal(inputBytes, null, 0);


Looks like you could get the inputBytes out of each of these else if {} blocks and do the convert* at the end if else block. that would prevent 10 uses of convert calls peppered across this method.

SandeepSutari · 2017-03-13T23:26:31Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+        /// that array on to the ConvertToHexidecimal method to output.
+        /// </summary>
+        /// <param name="_inputObject"></param>
+        private void ProcessObjectContent(PSObject _inputObject)


unless this is the pattern or a standard practice to use _ for private members we should avoid it. Also why is the method variable using the private member style...we should stick with camel casing since its a method variable.

parameter names shouldn't have '_' prefixed to them.

SandeepSutari · 2017-03-13T23:30:13Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+            else
+            {
+                string errorMessage = StringUtil.Format(UtilityCommonStrings.FormatHexTypeNotSupported, obj.GetType());
+                ErrorRecord errorRecord = new ErrorRecord(new ArgumentException(errorMessage),


I would fix indentation here

Fixed for all error messages.

SandeepSutari · 2017-03-13T23:32:59Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+            {
+                List<byte> inputStreamArray = new List<byte>();
+                Int64[] inputInts = (Int64[])obj;
+                foreach (Int64 i64 in inputInts)


i64 should get itself a better var name. currently its a type name.

You can do something like foreach (Int64 value in inputInts){...}

SandeepSutari · 2017-03-13T23:34:34Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+        /// <returns></returns>
+        private Encoding GetEncoding(string encoding)
+        {
+            if (String.Equals(encoding, "BigEndianUnicode", StringComparison.OrdinalIgnoreCase))


use string constants instead of raw strings

SandeepSutari

here are a few high level comments

SteveL-MSFT · 2017-03-13T23:39:33Z

githublog.log

@@ -0,0 +1,1225 @@
+**********************


this file shouldn't be part of the PR

SteveL-MSFT · 2017-03-13T23:41:55Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+        [ValidateNotNullOrEmpty()]
+        public string[] Path 
+        { 
+            get { return _path; }


convention is to use automatic properties:

public string[] Path { get; set; }

iSazonov · 2017-03-14T04:07:42Z

@MiaRomero Do you use the same e-mail for GitHub and CLA sign?

iSazonov · 2017-03-14T04:09:13Z

Add Breaking-Change because -Raw removed.

msftclas · 2017-03-14T16:19:23Z

@MiaRomero, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

Francisco-Gamino · 2017-03-14T06:17:37Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+    /// <summary>
+    /// Displays the hexidecimal equivalent of the input data.
+    /// <summary>
+    [Cmdlet(VerbsCommon.Format, "Hex", SupportsShouldProcess = true, HelpUri ="https://go.microsoft.com/fwlink/?LinkId=821773")]


The HelpUr should be "http://go.microsoft.com/fwlink/?LinkId=526919". This will fix your failures in the CI test pass.

Shouldn't this be https?

Francisco-Gamino · 2017-03-14T15:13:55Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+        /// Type of character encoding for InputObject
+        /// </summary>
+        [Parameter(ParameterSetName = "ByInputObject")]
+        [ValidateSet("Ascii", "UTF32", "UTF7", "UTF8", "BigEndianUnicode", "Unicode")]


As per @daxian-dbw suggestion, please see if you can reuse some of existing cmdlets' code that support encoding parameters.

You can probably reuse some of this code:

PowerShell/src/Microsoft.PowerShell.Commands.Utility/commands/utility/UtilityCommon.cs

Line 29 in 02b5f35

internal static Encoding GetEncodingFromEnum(TextEncodingType type)

yes, this should probably be an enum rather than the string set

In reply to: 105936094 [](ancestors = 105936094)

We have FileSystemCmdletProviderEncoding enum (but in EncodingConversion the same is string constants in the class.
It seems we need to bring this to the common code base.)

Francisco-Gamino · 2017-03-14T15:51:41Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+                        {
+                            // Write a non-terminating error message indicating that path specified is not supported.
+                            string errorMessage = StringUtil.Format(UtilityCommonStrings.FormatHexOnlySupportsFileSystemPaths, currentPath);
+                            ErrorRecord errorRecord = new ErrorRecord(new ArgumentException(errorMessage),


Please fix the indentation of all the errorrecords.

Francisco-Gamino · 2017-03-14T15:53:48Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+            {
+                List<byte> inputStreamArray = new List<byte>();
+                Int64[] inputInts = (Int64[])obj;
+                foreach (Int64 i64 in inputInts)


You can do something like foreach (Int64 value in inputInts){...}

Francisco-Gamino · 2017-03-14T16:13:42Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+
+        It "Validate the alias for Format-Hex cmdlet 'Get-Command fhx -ErrorAction Stop'" {
+
+            try


This test case could probably be simplified to:

{ Get-Alias fhx } | Should Not Throw

Francisco-Gamino · 2017-03-14T16:19:18Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

-    It "ValidateInteger64" {
+            $invalidPath = "$($inputFile1.DirectoryName)\fakefile8888845345345348709.txt"
+            $invalid2 = "C:\Windows\fakefile99342039847.txt"
+            $a = $null


Could you please use a more meaningful variable name? E.g., $output, and $errorThrown?

Francisco-Gamino · 2017-03-14T16:19:59Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+                InputObjectErrorCase = $true
+                Path = $inputFile1
+                InputObject = @{ "hash" = "table" }
+                expectedError = "FormatHexTypeNotSupported,Microsoft.PowerShell.Commands.FormatHex"


'expectedError' should be rename to 'expectedFullyQualifiedErrorId'.

Francisco-Gamino · 2017-03-14T16:20:53Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

-        $actualResult | should be "00000000   41 42 43 44                                      ABCD            "
+    Context "Correct Expected Errors" {
+
+        $otherProvider = Get-ChildItem Cert:\CurrentUser\My\


$otherProvider should probably be renamed to '$certificateProvider'.

Francisco-Gamino · 2017-03-14T16:22:42Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

-        $actualResult = $result.ToString()
-        # whitespace sensitive
-        $actualResult | should be "00000000   41 42 43 44                                      ABCD            "
+    Context "Correct Expected Errors" {


Could you please rename this Context to something like "Validate Format-Hex error scenarios" or "Validate negative test cases" or "Validate error scenarios"?

Francisco-Gamino · 2017-03-14T16:25:08Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+                Name = "Can process int[] type '[int[]](5,6) | fhx'"
+                inputObject = [int[]](5,6)
+                Count = 2
+                Expected = "00000000   05 00 00 00                                      ...."


Should these be ExpectedResult, and ExpectedSecondResult?

JamesWTruher · 2017-03-14T18:11:31Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+                foreach (string currentPath in path)
+                {
+                    string newPath = Context.SessionState.Path.GetUnresolvedProviderPathFromPSPath(currentPath);
+                    pathsToProcess.Add(newPath);


do you need to validate that these paths are filesystem provider paths?
for example, format-hex -literalpath hklm:/software should perhaps produce the same error as format-hex -path hklm:/software

JamesWTruher · 2017-03-14T18:13:45Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+                        {
+                            pathsToProcess.Add(newPaths[0]);
+                        }
+                    }


it seems like it would be a useful scenario to support multiple files here:
format-hex file*.txt
unless that's an explicit non-supported scenario

yep - looking below, it appears that it just loops through the provided paths, it seems reasonable to support more than one resolved path

In reply to: 105987086 [](ancestors = 105987086)

lzybkr

The file src\Modules\Unix\Microsoft.PowerShell.Utility\Microsoft.PowerShell.Utility.psd1 also needs updating - that should get the tests passing in Travis.

iSazonov · 2017-03-15T04:09:59Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

            $result | Should Not BeNullOrEmpty
-            $result.CommandType.ToString() | Should Be "Alias"
+            ,$result | Should BeOfType 'Microsoft.PowerShell.Commands.ByteCollection'
+            $actualResult = $result.ToString() -split "`r`n"


Please use platform independent [Environment]::NewLine

MiaRomero · 2017-03-15T20:22:25Z

Hi @SandeepSutari, @Francisco-Gamino, @SteveL-MSFT, @iSazonov, and @JamesWTruher,
Thank you for your feedback. I have addressed your comments - would you please take another look?
Thanks,
Maria

Francisco-Gamino · 2017-03-15T20:27:06Z

@iSazonov, @joeyaiello: I am removing "Breaking-Change" label as the -Raw parameter is still present (is a No-op).

SteveL-MSFT

My comments have been addressed. Thanks @MiaRomero !

lzybkr · 2017-03-15T20:47:15Z

@Francisco-Gamino - Even with the noop -Raw parameter - there is a change in behavior we need to document - so please keep the Breaking Change label.

daxian-dbw · 2017-03-15T20:55:27Z

It looks like we are using little-endian, since all windows version are little-endian. But since we are going cross-plat, maybe considering supporting big-endian as well? Or maybe at least document that we use little-endian by default?

lzybkr · 2017-03-15T20:59:57Z

@daxian-dbw - I don't think we want to get in the business of dealing with endian-ness in this cmdlet.

I think of it as more of a memory dumping tool, and it shouldn't necessarily interpret what it's dumping (even though we could).

lzybkr · 2017-03-15T20:34:05Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+        /// <param name="pathsToProcess"></param>
+        private void ProcessPath(List<string> pathsToProcess)
+        {
+            // If there are no paths to proccess, just return.


The test Count == 0 is not necessary if we aren't reporting any errors, the foreach statement handles that case cleanly and efficiently.

That said, should we report an error if there are no files?

Thank you. Good point, it turns out we do not need this code. It does throw an error if the path does not resolve to a file.

The sample below shows an array of two paths that don't exist. Each will throw a non-terminating error.

fhx -Path "c:\dlfkjasdkfj.txt", "c:\ldkfj.txt" fhx : Cannot find path 'C:\dlfkjasdkfj.txt' because it does not exist. At line:1 char:1 + fhx -Path "c:\dlfkjasdkfj.txt", "c:\ldkfj.txt" + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : ObjectNotFound: (System.String[]:String[]) [Format-Hex], ItemNotFoundException + FullyQualifiedErrorId : FileNotFound,Microsoft.PowerShell.Commands.FormatHex fhx : Cannot find path 'C:\ldkfj.txt' because it does not exist. At line:1 char:1 + fhx -Path "c:\dlfkjasdkfj.txt", "c:\ldkfj.txt" + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : ObjectNotFound: (System.String[]:String[]) [Format-Hex], ItemNotFoundException + FullyQualifiedErrorId : FileNotFound,Microsoft.PowerShell.Commands.FormatHex

And just to confirm - there is no error if you use a wildcard and there are no matches?

lzybkr · 2017-03-15T20:38:40Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+                            // will just contain multiple references to the same buffer memory space (containing only the
+                            // last bytes of the file read).  Cloning the buffer allows us to pass the values on without
+                            // overwriting previous values.
+                            byte[] bufferClone = (byte[])buffer.Clone();


Clone is copying data needlessly here.

Instead, you could pass buffer to ConvertToHexidecimal, then create a new array that is zero initialized. The zeroing of memory by .Net is going to be more efficient than the Clone (which will have started with zeroed memory anyway).

I've changed it to copy the buffer into a new array instead of cloning the buffer. If this isn't what you had in mind, please file an issue and @Francisco-Gamino will follow up. Due to time constraints with my internship, I won't be able to follow up after today.

lzybkr · 2017-03-15T20:48:54Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+        {
+            Object obj = inputObject.BaseObject;
+            byte[] inputBytes = null;
+            if (obj is System.IO.FileSystemInfo)


I know this is just a translation of the C#, but I don't think this case makes sense.

If I pass an object for Format-Hex, I expect that object to be formatted. I didn't ask for the contents of the file, that's a different parameter set.

Per committee review/comment below, we'll leave as is for now.

lzybkr · 2017-03-15T22:12:53Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+                inputBytes = resolvedEncoding.GetBytes(inputString);
+            }
+
+            else if (obj is byte)


It would be nice to see all primitive types (including enums) and arrays of these types - instead of this random assortment.

I wrote some code that covers much of what I think is useful and it's a similar number of lines of code, see https://gist.github.com/lzybkr/9940b63c8301c31316bdb3ec6305536f

It might also be useful to support any value type, not just primitives, but that is a little harder.

Hi @lzybkr, @MiaRomero Leap Program assignment/internship ends today, so I will follow-up on this. I have open an issue #3358 to track this. Thanks.

lzybkr · 2017-03-15T22:14:34Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+
+            foreach (string path in pathsToProcess)
+            {
+                ProcessFileContent(path);


It doesn't look like there is any file header, so if there are multiple files, it will be difficult to understand the output.

There is a header for each ByteCollection object, e.g.,

New-Item -Value "foo" -Path foo1.txt -ItemType File
New-Item -Value "foo2" -Path foo2.txt -ItemType File

PS C:\exp> dir foo* | fhx Path: C:\exp\foo1.txt 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F 00000000 66 6F 6F foo Path: C:\exp\foo2.txt 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F 00000000 66 6F 6F 32 foo2 PS C:\exp> fhx -Path .\foo* Path: C:\exp\foo1.txt 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F 00000000 66 6F 6F foo Path: C:\exp\foo2.txt 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F 00000000 66 6F 6F 32 foo2

SteveL-MSFT · 2017-03-15T23:36:43Z

@PowerShell/powershell-committee reviewed this and agreed on:

for numbers, we should prefix with 0 to retain width
change to formatting (due to storing in property) is a breaking change that just needs to be documented
if array is passed in, then each element in the array is a separate output object
FileInfo retains current behavior (special cased to format the content)

iSazonov · 2017-03-16T03:43:02Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

-        ,$result | Should BeOfType 'Microsoft.PowerShell.Commands.ByteCollection'
-        $actualResult = $result.ToString()
-        ($actualResult -match $inputText1) | Should Be $true
+        $errorThrown | Should Not Be $null


It seems like this is unnecessary and should be removed.

In this scenario we want to test that we get both an error and output.

iSazonov · 2017-03-16T03:46:26Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+        }
+
+        $thrownError | Should Not Be $null
+        $thrownError.FullyQualifiedErrorId | Should Match $testCase.ExpectedFullyQualifiedErrorId


Please use the template to check FullyQualifiedErrorId

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/Start-Process.Tests.ps1

Line 89 in 7f83c48

{ Start-Process -FilePath $pingCommand -WindowStyle Normal } | ShouldBeErrorId "NotSupportedException,Microsoft.PowerShell.Commands.StartProcessCommand"

I've tried using this but get this error:
The term 'ShouldBeErrorId' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

So for now I'll keep Should Match

iSazonov · 2017-03-16T03:57:55Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+
+        foreach ($testCase in $testCases)
+        {
+            RunPathAndLiteralPathParameterTestCase $testCase


We could call the function with parameter PathCase = $true then PathCase = $false

Yes, that is true. But I'll leave as is for now.

iSazonov · 2017-03-16T04:46:43Z

test/powershell/Modules/Microsoft.PowerShell.Utility/FormatHex.Tests.ps1

+
+        It "Validate the alias (fhx) for Format-Hex cmdlet is available" {
+
+            { Get-Alias fhx } | Should Not Throw


Please remove the test because we already have separate files with tests for aliases.

rkeithhill · 2017-03-20T23:18:41Z

...rosoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs

+    {
+        private const int BUFFERSIZE = 16;
+
+        #region Parameters


Is there any chance we could get Count and Offset parameters? I could probably live without Offset but on the PSCX Format-Hex command, I use -Count almost all the time. That's because I use it to see if a text file has a BOM, in which case I only want to see the first 3 characters.

Those are good suggestions, but out of scope for this PR.

@rkeithhill, please open a issue for that suggestion. Thanks.

MiaRomero · 2017-03-21T05:12:26Z

Thank you everyone for your feedback. @lzybkr can you please merge when you have a chance? My internship is over so if there are any questions/concerns please address them to @Francisco-Gamino. Thanks!

Francisco-Gamino · 2017-03-21T05:19:33Z

It was great working with you @MiaRomero, thank you!

lzybkr

I opened #3382 so we clean up the test a little, but otherwise looks good.

Francisco-Gamino · 2017-03-21T19:46:03Z

Thanks @lzybkr! I will take care of #3382.

msftclas added the cla-required label Mar 13, 2017

Francisco-Gamino requested a review from JamesWTruher March 13, 2017 19:30

Francisco-Gamino requested review from JamesWTruher and removed request for JamesWTruher March 13, 2017 19:37

Francisco-Gamino assigned MiaRomero Mar 13, 2017

lzybkr assigned lzybkr and unassigned MiaRomero Mar 13, 2017

SandeepSutari reviewed Mar 13, 2017

View reviewed changes

SandeepSutari suggested changes Mar 13, 2017

View reviewed changes

SteveL-MSFT requested changes Mar 13, 2017

View reviewed changes

iSazonov added the Breaking-Change breaking change that may affect users label Mar 14, 2017

msftclas added cla-signed and removed cla-required labels Mar 14, 2017

Francisco-Gamino suggested changes Mar 14, 2017

View reviewed changes

JamesWTruher reviewed Mar 14, 2017

View reviewed changes

Francisco-Gamino added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Mar 15, 2017

lzybkr reviewed Mar 15, 2017

View reviewed changes

iSazonov reviewed Mar 15, 2017

View reviewed changes

MiaRomero force-pushed the formatHex branch from 91602a0 to 6e11912 Compare March 15, 2017 20:18

Francisco-Gamino removed the Breaking-Change breaking change that may affect users label Mar 15, 2017

SteveL-MSFT approved these changes Mar 15, 2017

View reviewed changes

lzybkr added the Breaking-Change breaking change that may affect users label Mar 15, 2017

lzybkr suggested changes Mar 15, 2017

View reviewed changes

SteveL-MSFT added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Mar 15, 2017

iSazonov reviewed Mar 16, 2017

View reviewed changes

rkeithhill reviewed Mar 20, 2017

View reviewed changes

SandeepSutari approved these changes Mar 20, 2017

View reviewed changes

Francisco-Gamino approved these changes Mar 21, 2017

View reviewed changes

Implement Format-Hex in C#

6b96500

MiaRomero force-pushed the formatHex branch 2 times, most recently from 971954d to 41f6b10 Compare March 21, 2017 04:37

Update Format-Hex test cases and add new tests for added functionality

7382640

MiaRomero force-pushed the formatHex branch from 41f6b10 to 7382640 Compare March 21, 2017 04:53

lzybkr approved these changes Mar 21, 2017

View reviewed changes

lzybkr merged commit 0e12fbf into PowerShell:master Mar 21, 2017

matt9ucci mentioned this pull request Dec 10, 2017

Format-Hex -Raw parameter is not documented MicrosoftDocs/PowerShell-Docs#1940

Closed

7 tasks

mklement0 mentioned this pull request Sep 26, 2018

Can we hide obsolete or internal-use-only helper parameters from syntax diagrams? #7868

Closed

MiaRomero mentioned this pull request Nov 5, 2018

Format-Hex should support all primitive types (including enums) and arrays of these types - instead of this random assortment. #3358

Closed


		It "Validate the alias for Format-Hex cmdlet 'Get-Command fhx -ErrorAction Stop'" {

		try


		It "Validate the alias (fhx) for Format-Hex cmdlet is available" {

		{ Get-Alias fhx } \| Should Not Throw

Implement Format-Hex in C# #3320

Implement Format-Hex in C# #3320

Uh oh!

Conversation

MiaRomero commented Mar 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msftclas commented Mar 13, 2017

Uh oh!

Francisco-Gamino commented Mar 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SandeepSutari left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iSazonov commented Mar 14, 2017

Uh oh!

iSazonov commented Mar 14, 2017

Uh oh!

msftclas commented Mar 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MiaRomero commented Mar 13, 2017 •

edited

Loading