Skip to content

Conversation

PaulHigin
Copy link
Contributor

PR Summary

This PR removes the implicit remoting batching experimental feature.

PR Context

It was decided by committee (#15862) to remove this experimental feature. It was an interesting idea but the implementation did not cover important cases, and could not be updated easily to do so.

PR Checklist

@ghost ghost assigned iSazonov Aug 3, 2021
@PaulHigin PaulHigin requested review from SteveL-MSFT and JamesWTruher and removed request for daxian-dbw and anmenaga August 3, 2021 21:58
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intention do not remove all from https://github.com/PowerShell/PowerShell/pull/8038/files?

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Aug 4, 2021
@PaulHigin
Copy link
Contributor Author

@iSazonov Thanks! I'll remove the other supporting changes as well.

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov
Copy link
Collaborator

iSazonov commented Aug 5, 2021

@PaulHigin Please look test fails.

@ghost ghost added the Review - Needed The PR is being reviewed label Aug 13, 2021
@ghost
Copy link

ghost commented Aug 13, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov merged commit 1ec61d9 into PowerShell:master Aug 13, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 13, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.9 milestone Aug 13, 2021
xtqqczze pushed a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request Aug 20, 2021
It was decided by committee (PowerShell#15862) to remove this experimental feature. It was an interesting idea but the implementation did not cover important cases, and could not be updated easily to do so.
@ghost
Copy link

ghost commented Aug 23, 2021

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Sep 28, 2021

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants