Skip to content

Make classes sealed #15675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2021
Merged

Make classes sealed #15675

merged 2 commits into from
Jul 4, 2021

Conversation

xtqqczze
Copy link
Contributor

Contributes to #15110.

Fix RCS1225: Make class sealed

Contains internal, private changes from 2069d92 (#11773).

@ghost ghost assigned anmenaga Jun 25, 2021
@xtqqczze xtqqczze mentioned this pull request Jun 25, 2021
Closed
8 tasks
@xtqqczze
Copy link
Contributor Author

CodeFactor new Complex Method issues are false positives.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 25, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Jul 3, 2021
@ghost
Copy link

ghost commented Jul 3, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Jul 4, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 4, 2021
@iSazonov iSazonov merged commit 4c2d6dc into PowerShell:master Jul 4, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.8 milestone Jul 4, 2021
@xtqqczze xtqqczze deleted the static-classes branch July 4, 2021 19:30
@xtqqczze xtqqczze mentioned this pull request Jul 6, 2021
Closed
@ghost
Copy link

ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

Assignees

@iSazonov iSazonov

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.8
Development

Successfully merging this pull request may close these issues.
3 participants
@xtqqczze @iSazonov @anmenaga