Skip to content

Fix RCS1188: Remove redundant auto-property initialization part 2 #14262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2020
Merged

Fix RCS1188: Remove redundant auto-property initialization part 2 #14262

merged 3 commits into from
Dec 4, 2020

Conversation

xtqqczze
Copy link
Contributor

src\Microsoft.PowerShell.Commands.Utility\Microsoft.PowerShell.Commands.Utility.csproj

Follow-up to #14244.

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1188.md

@ghost ghost assigned rjmholt Nov 25, 2020
@xtqqczze
Copy link
Contributor Author

restarting tests

@xtqqczze xtqqczze closed this Nov 25, 2020
@xtqqczze xtqqczze reopened this Nov 25, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 3, 2020
rjmholt
rjmholt reviewed Dec 3, 2020
View reviewed changes
@rjmholt rjmholt requested a review from SteveL-MSFT December 3, 2020 17:56
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 3, 2020 •
edited
Loading 

Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/dev-process/coding-guidelines.md.https://docs.microsoft.com/dotnet/csharp/programming-guide/xmldoc/xml-documentation-comments should work
Failed to complete request to "https://docs.microsoft.com/dotnet/csharp/programming-guide/xmldoc/xml-documentation-comments". Response status code does not indicate success: 404 (Not Found).

Issue opened: #14313.

@xtqqczze
revert change
3641aaa 
address @iSazonov review
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 4, 2020
@iSazonov iSazonov assigned iSazonov and unassigned rjmholt Dec 4, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 4, 2020
@iSazonov iSazonov merged commit 75b5813 into PowerShell:master Dec 4, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 4, 2020
@xtqqczze xtqqczze deleted the RCS1188-p2 branch December 4, 2020 11:56
@ghost
Copy link

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

+1 more reviewer

@rjmholt rjmholt rjmholt left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@iSazonov iSazonov

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.2
Development

Successfully merging this pull request may close these issues.
3 participants
@xtqqczze @rjmholt @iSazonov