Fix IDE0044: MakeFieldReadonly part 11 #13966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src\System.Management.Automation\engine\remoting\
iSazonov
approved these changes
Nov 3, 2020
iSazonov
added
the
CL-CodeCleanup
PaulHigin
suggested changes
Nov 3, 2020
src/System.Management.Automation/engine/remoting/client/ClientMethodExecutor.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/remoting/commands/newrunspacecommand.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/remoting/common/throttlemanager.cs
Show resolved
Hide resolved
ghost
added
the
Waiting on Author
|
@xtqqczze Please look @PaulHigin's comments. |
ghost
removed
the
Waiting on Author
|
@PaulHigin Please update your review. |
|
@iSazonov I'll approve once all requested changes are made. |
8 tasks
|
@xtqqczze Please look new comments. |
PaulHigin
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
Split from #13880 to ease review.
src\System.Management.Automation\engine\remoting\