Adds Mask Input Parameter to Read-Host

[davinci26]

PR Summary

Issue

Adds #10847

Implementation

• Extend the PSHostUserInterface class with a virtual method ReadLineMaskedAsString. This method is in between ReadLine and ReadLineAsSecureString.
• Implement the new method in the InternalHostUserInterface.cs
• I provided a default implementation in the Interface which just throws an exception to make this change backward compatible.
• Check at runtime if the user has provided both -MaskInput and -AsSecureString and if so throw an exception. Use parameter sets to make -MaskInput and -AsSecureString mutually exclusive (this is another application for Parameters Should Support Mutual Exclusion Natively #5175)

Happy Hacktoberfest!

PR Context

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed: Document Read-Host new parameter called MaskInput MicrosoftDocs/PowerShell-Docs#5021

• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[TravisEz13]

My concern would be that this, https://github.com/PowerShell/PowerShell/pull/10908/files#diff-fff8012934f59c558d7de1adeca99bf1R208, is used in some existing remoting scenario.

GitHub

Adds Mask Input Parameter to Read-Host by davinci26 · Pull Request #10908 · PowerShell/PowerShell

PR Summary Issue Adds #10847 Implementation

Extend the PSHostUserInterface class with a virtual method ReadLineMaskedAsString. This method is in between ReadLine and ReadLineAsSecureString.
Implem...

[SteveL-MSFT]

@PowerShell/powershell-committee reviewed this and is ok with the proposed switch name and functionality.

[SteveL-MSFT]

@davinci26 can you resolve the merge conflict?

[davinci26]

@PoshChan please retry windows and static

[PoshChan]

@davinci26, you are not authorized to request a rebuild

[davinci26]

@SteveL-MSFT FYI I have fixed all merge conflicts.

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

[iSazonov]

@TravisEz13 It seems the PR ready to merge.

[iSazonov]

@davinci26 Thanks for your contribution!

[ghost]

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes