Hide the console for WinRM remoting #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
approved these changes
Dec 15, 2022
iSazonov
reviewed
Dec 15, 2022
| @@ -39,6 +39,13 @@ unsigned int PowerShellCoreClrWorker::LaunchClr( | |||
| { | |||
| // Allocate a console so that the codepage is setup correctly | |||
| AllocConsole(); | |||
| HWND console = GetConsoleWindow(); | |||
| if (console != NULL) | |||
There was a problem hiding this comment.
AllocateConsole returns HWND and since winrm haven't a console before the call returns real handle. It seems we have no need to call GetConsoleWindows.
https://learn.microsoft.com/en-us/windows/console/allocconsole
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The change to allocate a console so that the codepage is set correctly had the side effect of showing the console. This change was deemed least risky to hide the console immediately. Downside is there can be a flash of the console, but we can consider other fixes longer term with proper validation while this is needed to be backported to 7.3
PR Context
Fix #85