Renames CustomizedRulePath parameter and modifies its behavior. #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renames CustomizedRulePath parameter to CustomRulePath. * Adds CustromizedRulePath as an alias of CustomRulePath. * Adds RecurseCustomRulePath switch to recursively retrieve custom rules. * Fixes a bug: CustomRulePath can now accept paths with a trailing backslash. * CustomRulePath parameter now takes only one string, instead of an array of strings.
|
Thanks so much! When this PR is accepted, I'll fix the help file. |
added 5 commits
November 20, 2015 16:24
We have set the CustomRulePath parameter in the cmdlet implementation in LibraryUsage.tests.ps1 to "string[]" type whereas in the c# implementation it is of "string" type. If we set the CustomRulePath parameter here to "string", then the library usage test fails when run as an administrator. We want to note that the library usage test doesn't fail when run as a non-admin user. Even if we create a "[string[]]" type object and pass it to Initialize method, the tests fail to run as an admin with the following error message. Assert failed on "Initialize" with "7" argument(s): "Test failed due to terminating error: The module was expected to contain an assembly manifest. (Exception from HRESULT: 0x80131018)
|
Sign-off. |
kapilmb
pushed a commit
that referenced
this pull request
Nov 23, 2015
…Backslash Renames CustomizedRulePath parameter and modifies its behavior.
This was referenced Nov 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backslash.
of strings.