Initial commit for ScriptDefinition #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Quoc. Are the failing tests taken care of? |
|
looks good.. I am assuming there are no breaking changes here. |
|
The only thing that may cause a breaking change is the ParameterSet. But I put the file path into the default parameter set so that shouldn't break any thing that depends on scriptanalyzer. |
|
great. then we can leave the major version as is |
|
merge.. |
quoctruong
pushed a commit
that referenced
this pull request
Nov 12, 2015
Initial commit for ScriptDefinition
|
Merged. Thanks |
This was referenced Nov 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a parameterset called ScriptDefinition. This parameterset has a parameter called ScriptDefinition which takes in a script in the form of a string. Rename the default parameter set to File.