-
Notifications
You must be signed in to change notification settings - Fork 317
Update PSReadLine corresponding to the prediction interface update #2225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as-kien
reviewed
Feb 19, 2021
SteveL-MSFT
requested changes
Feb 22, 2021
adityapatwardhan
approved these changes
Feb 22, 2021
SteveL-MSFT
requested changes
Feb 22, 2021
SteveL-MSFT
approved these changes
Feb 23, 2021
Member
Author
|
The Aladdin team confirmed that the PSReadLine, PowerShell 7.2.0-preview.3, and Az.Predictor are working as expected end-to-end. I will merge this PR and get ready for the 2.2.0-beta2 release. |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #2221
Major changes:
OnSuggestionDisplayedfeedbackPSReadLine, as well as the predictor mini-session id, when providing feedback.PowerShell 7.2.0-preview.3NuGet packagesPR Checklist
Microsoft Reviewers: Open in CodeFlow