Fix for Y2038 gettimeofday for Win32 builds #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Microsoft" |
This was referenced Aug 7, 2024
|
these changes were merged as part of #34 so I'm going to close this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fist part of the Y2038 issue on OpenSSH. Second part here: PowerShell/openssh-portable#738
Porting LibreSSL fix (libressl/portable#1078) for gettimeofday on MSVC builds.
timeval was taken from winsock2.h that is 32bit signed.
PR Context
Besides overriding gettimeofday and timeval on MSVC platforms, we also need to modify the gettimeofday export of the dll with the overriden name openlss_gettimeofday on crypto/CMakeLists.txt.