Skip to content

Update Current to current for securityContext schema #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Gijsreyn
Copy link
Contributor

PR Summary

This pull request is a minor change to reflect all schemas to current for the securityContext canonical property.

PR Context

Fix #1055

@Gijsreyn Gijsreyn force-pushed the fix-securitycontext-current branch from daef381 to 5a2d999 Compare August 24, 2025 21:03
Copy link
Collaborator

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

It looks like you went through to fix the composed schemas directly.

What we actually want to do is:

  1. Update the following line in schemas/src/config/document.metadata.yaml:

  2. Regenerate the schemas for only the v3* version folders.

We don't want to modify the schemas for 2024/04, because those map to before we canonicalized the casing for enums.

@Gijsreyn Gijsreyn force-pushed the fix-securitycontext-current branch from 5a2d999 to fa9feb1 Compare August 27, 2025 00:38
@Gijsreyn
Copy link
Contributor Author

Hi Mikey,

Thanks for checking the pull request. I was already afraid that I was doing something wrong. I had tried running the build.ps1 script in the schemas directory, but couldn't get it to work. I guess I had the powershell-yaml module installed, rather than the yayaml. Anyway, the steps that I did now:

  1. Change what you suggested in step 1.
  2. Run the build.ps1 script for each v3.* version by modifying the schemas.config.yaml file.

Hope that these are the steps.

Copy link
Collaborator

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a lot of files got inadvertent updates because of the complexity for regenerating schemas. I'm going to see if I can tackle the build to filter these values based on the target version (e.g. v3.0.0 shouldn't consider later versions at all, v3.0 shouldn't consider 3.1 or later, v3 shouldn't consider 4.0.0 or later).

For now, I consider my initial recommendation to be erroneous - instead of updating source and regenerating, we should just update source and the generated schemas. I'll have to tackle the build separately. I'm going to take over this PR to get it into a mergeable state, since it's my fault that the changes ended up like this.

@Gijsreyn
Copy link
Contributor Author

Solid copy, sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

securityContext default value is invalid
2 participants