[IMPROVEMENT] Pandapower_convert gives NaN for tan1, the positive-sequence shunt loss factor

[Plusero]

Describe the problem

When c_nf_per_km line shunt capacitance equals to 0 in PandaPower, PGM-io sets tan1 to NaN due to division by zero at line 426 in pandapower_converter.py. However, assert_valid_input_data in PGM does not accept NaN values for tan1.

Improvement proposal

When c_nf_per_km line shunt capacitance equals to 0 in PandaPower, setting tan1 to 0. This matches the the fact that c_nf_per_km = 0 means no shunt capacitance, and therefore no tan1, the positive-sequence shunt loss factor.

Details see the attached Jupyter notebook.

requirements.txt
ieee14_conversion.ipynb

[nitbharambe]

Nice find @Plusero .
The improvement proposal would do. Feel free to create a PR for this.

[furqan463]

@petersalemink95 @nitbharambe since I already had an open PR #320 focused on Pandapower_converter, I added the fix for this issue in that PR.

[Plusero]

Nice find @Plusero . The improvement proposal would do. Feel free to create a PR for this.

Oh, I've forgot to create the PR while focusing on my own stuff. But now it is fixed already. So, no more issues with this topic from me:)