Gtm matm optimizations #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyamakgec
suggested changes
Mar 18, 2019
| uint256[] memory _fromTime, | ||
| uint256[] memory _toTime, | ||
| uint256[] memory _expiryTime | ||
| uint64[] memory _canSendAfter, |
Contributor
There was a problem hiding this comment.
in 2.1.0 you used uint256 in function arguments and then typecast those into uint64 in the function body. Shouldn't we make consistency in both branches
Contributor
Author
There was a problem hiding this comment.
We used uint256 in 2.1 to make the interface compatible with 2.0. (We want to use the same dApp on 2.0 and 2.1 version of security token/modules)
There is no need to keep 3.0 and 2.1 compatible as they will require different dApps anyway.
satyamakgec
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported changes from #601