- 
                Notifications
    You must be signed in to change notification settings 
- Fork 152
Fetch poly token from pm registry #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    maxsam4
  
              
              reviewed
              
                  
                    Dec 7, 2018 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update CHANGELOG, please.
Everything else looks good to me.
              
                    satyamakgec
  
              
              suggested changes
              
                  
                    Dec 7, 2018 
                  
              
              
            
            
| CHANGELOG has been updated. | 
              
                    maxsam4
  
              
              approved these changes
              
                  
                    Dec 8, 2018 
                  
              
              
            
            
              
                    satyamakgec
  
              
              approved these changes
              
                  
                    Dec 9, 2018 
                  
              
              
            
            
  This was referenced Apr 17, 2024 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Instead of manually entering the PolyToken on the deployment of each contract, have them fetch it from the PMRegistry.
Does this PR introduce a breaking change?
Any Other information: