Signed transfer manager fixed #410
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdossa
suggested changes
Nov 14, 2018
adamdossa
suggested changes
Nov 16, 2018
maxsam4
suggested changes
Nov 16, 2018
as requested by Adam D.
gas saver Co-Authored-By: comeonbuddy <[email protected]>
data input length can not be 0
maxsam4
reviewed
Nov 16, 2018
maxsam4
reviewed
Nov 16, 2018
adamdossa
approved these changes
Nov 26, 2018
maxsam4
approved these changes
Dec 11, 2018
Contributor
|
Closing in favor of #533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
fixed signed transfer manager and test filess
What is the current behavior?
current signed transfer manager was not working due to a pending issue we have double pre fix when signing messages because our version of web3 automatically adds one.
What is the new behavior?
fixed the issue so the test file work
Does this PR introduce a breaking change?
no
Any Other information: