Skip to content

Conversation

@maxsam4
Copy link
Contributor

@maxsam4 maxsam4 commented Oct 16, 2018

npm run wintest -> Run tests on windows
npm run wincov -> Run coverage on windows

@maxsam4 maxsam4 requested a review from VictorVicente October 16, 2018 10:49
@VictorVicente
Copy link
Contributor

I'll try it in an hour, looks good.
What do you think about using a package like run-script-os (https://www.npmjs.com/package/run-script-os) or similar, to have an unified test command?

@maxsam4
Copy link
Contributor Author

maxsam4 commented Oct 16, 2018

What do you think about using a package like run-script-os to have an unified test command?

I am neutral on the issue. On one hand, we get unified command and on the other, an additional dependency. I'll see if I can make our script unified without the need of an additional package.

@maxsam4
Copy link
Contributor Author

maxsam4 commented Oct 16, 2018

I was able to make a unified script but it needs to be placed in root directory of the repo as path definition are different on windows. I would prefer using the node module or non-unified commands over placing a script in the root of the repo.

@pabloruiz55 pabloruiz55 merged commit 1a38304 into development-1.5.0 Oct 16, 2018
@maxsam4 maxsam4 deleted the windows-support branch January 11, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants