Add additional transfer / mint / burn functions with _data parameter #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyamakgec
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds transfer, mint & burn functions with an additional
bytes _dataparameter which is passed onto TransferManagers.This would allow us to do off-chain whitelisting - for example if an exchange is generating a dynamic deposit address for a customer they could also provide a signed piece of data which authorises this address (assuming the issuer had added a TM that accepted this signed data).
More or less inspired from ERC 1400 although more ERC20 like in naming.
For the burn functions, I didn't include the non-data versions as these aren't part of the ERC20 specification in any case (probably the same argument could be made for mint, but that is already used in lots of places so I left the old version of the function).