Freeze Minting

[thegostep]

Requirements

• Issuer MUST be able to call a function which prevents them from minting tokens in the future
• This issue MUST be disabled by default until enabled by Polymath
• Function MUST emit event notifying minting is done
• Issuer MUST be able to mint tokens at any time before calling this function
• Issuer MUST NOT be able to mint tokens at any time after calling this function

Changes

ISecurityToken.sol

• remove function finishMintingIssuer() and function finishMintingSTO()
• add function freezeMinting()

SecurityToken.sol

• rename bool freeze to bool transfersFrozen
• add bool mintingFrozen
• remove bool finishedIssuerMinting and bool finishedSTOMinting
• remove event LogFinishMintingSTO and event LogFinishMintingIssuer
• add event LogFreezeMinting
• remove function finishMintingIssuer() and function finishMintingSTO()
• add function freezeMinting()
• change modifier isMintingAllowed to only check for mintingFrozen
• change modifier onlyModule() to remove fallback on onlyOwner
• add modifier onlyModuleOrOwner()

create IFeatureRegisty.sol
create FeatureRegisty.sol

RegistryUpdater.sol

• add featureRegistry

[pabloruiz55]

What's the reasoning behind putting the Polymath allowFreezeMinting switch in the ModuleRegistry? Not that any of the other registries make more sense, though.
Perhaps what's more sensible to do is to create a new Polymath owned registry where all these regulatory feature switches go in, rather. @thegostep

[thegostep]

@pabloruiz55 The reason for putting the feature switch in the MR is because it is the only registry with a link to the deployed ST since they communicate for module deployment. WRT a new feature switch contract, it seems like a bit of an overkill and would create additional dependencies. I am still not familiar with the new upgradability pattern so not sure what will be the implications. Maybe @adamdossa has more thoughts.

[pabloruiz55]

@thegostep WRT where this switch goes, let's keep it simple for now:

1. Create new registry contract and move the logic added to the MR there.
2. Add that contract to the PolymathRegistry as a new key
3. From the SecurityToken contract you can access the new contract through the PolymathRegistry and get the flag.