Skip to content

fix: dependency reference #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix: dependency reference #6

merged 2 commits into from
Jul 1, 2024

Conversation

@clemblanco
Copy link
Contributor

@clemblanco clemblanco commented Jul 1, 2024 •
edited
Loading

  • A Laravel package should never require laravel/laravel as this is a "dist" repo but instead should use sub-repositories such as illuminate/* otherwise this will cause the following warnings from composer

image

clemblanco added 2 commits July 1, 2024 15:16
@clemblanco
fix: dependency reference
0ffdc7b 
- A Laravel package should never require `laravel/laravel` as this is a "dist" repo but instead should use sub-repositories such as `illuminate/*`.
@clemblanco
WIP
bd0bbfb
@clemblanco clemblanco merged commit d666a1d into master Jul 1, 2024
@clemblanco clemblanco deleted the fix-laravel-dependencies branch July 1, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmy718 jimmy718 jimmy718 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clemblanco @jimmy718