Add error handling for eventbridge put events #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemblanco
reviewed
Sep 28, 2023
clemblanco
approved these changes
Sep 28, 2023
Contributor
|
Thanks @FRoepstorf for your contribution! ✌️ |
Merged
clemblanco
added a commit
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During debugging I noticed that this library fails silently on eventbridge
putEvents, by not evaluating theAws\Resultclass that is returned from theputEventsmethod.For our case it was enough to just log the error to be able to troubleshoot it, but mit might be worth to throw an exception when this occurs. But to not break existing flows, I leave it to the maintainers to decide.