Implemented feature to gray out all controls if they are disabled #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current color controls keep their state even if they are disabled. However, this can be confusing for users because there is no visual feedback that the controls are disabled. This PR changes this behavior by using the luminance of a color as the gray value.
Enabled Controls
Disabled Controls
Breaking Changes
This PR changes the visual behavior of the color controls so if developers used the disabled state to just display the color, this PR will break this. However, I would argue that the color controls are primarily to control the color values and not just to display them. If such a display option is needed, an additional "KeepColorWhileDisabled" DP could be added to the controls.