Google Sheets async options - add option to fetch only owned #17884
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update consists primarily of version number increments across multiple Google Sheets action and source components, as well as the package manifest. The only functional change is in the main app file, where the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant sheetID.options
participant listSheetsOptions
participant Google Drive API
User->>sheetID.options: Call with (query, fetchOnlyOwned)
sheetID.options->>listSheetsOptions: Pass (driveId, pageToken, query, fetchOnlyOwned)
listSheetsOptions->>Google Drive API: Query spreadsheets (optionally filter by owner)
Google Drive API-->>listSheetsOptions: Return spreadsheet list
listSheetsOptions-->>sheetID.options: Return filtered options
sheetID.options-->>User: Return available spreadsheet options
Estimated code review effort🎯 2 (Simple) | ⏱️ ~6 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
components/google_sheets/actions/clear-cell/clear-cell.mjs (1)
10-10: Incremented version—remember to update release notesThe patch bump from
0.1.13→0.1.14looks fine. Please ensure the component-level CHANGELOG (if maintained) reflects this increment so downstream consumers can track the release rationale.components/google_sheets/actions/get-values-in-range/get-values-in-range.mjs (1)
10-10: Version bump noted—sync documentation
0.1.11→0.1.12is OK. Verify that any public docs or marketplace metadata reference the new version to avoid mismatched installation instructions.components/google_sheets/actions/update-row/update-row.mjs (1)
13-13: Patch version updated—double-check semver intentMoving to
0.1.13signals a bug-fix level change. Since no logic changed, confirm that bumping was intentional and aligns with your publishing workflow (e.g., ensuring each monorepo release gets a fresh patch even for meta updates).components/google_sheets/actions/upsert-row/upsert-row.mjs (1)
27-27: Version increment loggedPatch bump to
0.1.14acknowledged. Make sure package.json’s dependency map (if any) is updated so consumers pulling@pipedream/[email protected]receive this action version.components/google_sheets/sources/new-row-added/new-row-added.mjs (1)
11-11: Source version bumped—update sample events if necessary
0.1.14recorded. If the only change is metadata, the existing sample event remains valid; otherwise refreshsampleEmitto reflect any schema tweaks.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (28)
components/google_sheets/actions/add-column/add-column.mjs(1 hunks)components/google_sheets/actions/add-multiple-rows/add-multiple-rows.mjs(1 hunks)components/google_sheets/actions/add-single-row/add-single-row.mjs(1 hunks)components/google_sheets/actions/clear-cell/clear-cell.mjs(1 hunks)components/google_sheets/actions/clear-rows/clear-rows.mjs(1 hunks)components/google_sheets/actions/copy-worksheet/copy-worksheet.mjs(1 hunks)components/google_sheets/actions/create-spreadsheet/create-spreadsheet.mjs(1 hunks)components/google_sheets/actions/create-worksheet/create-worksheet.mjs(1 hunks)components/google_sheets/actions/delete-rows/delete-rows.mjs(1 hunks)components/google_sheets/actions/delete-worksheet/delete-worksheet.mjs(1 hunks)components/google_sheets/actions/find-row/find-row.mjs(1 hunks)components/google_sheets/actions/get-cell/get-cell.mjs(1 hunks)components/google_sheets/actions/get-spreadsheet-by-id/get-spreadsheet-by-id.mjs(1 hunks)components/google_sheets/actions/get-values-in-range/get-values-in-range.mjs(1 hunks)components/google_sheets/actions/insert-anchored-note/insert-anchored-note.mjs(1 hunks)components/google_sheets/actions/insert-comment/insert-comment.mjs(1 hunks)components/google_sheets/actions/list-worksheets/list-worksheets.mjs(1 hunks)components/google_sheets/actions/update-cell/update-cell.mjs(1 hunks)components/google_sheets/actions/update-multiple-rows/update-multiple-rows.mjs(1 hunks)components/google_sheets/actions/update-row/update-row.mjs(1 hunks)components/google_sheets/actions/upsert-row/upsert-row.mjs(1 hunks)components/google_sheets/google_sheets.app.mjs(2 hunks)components/google_sheets/package.json(1 hunks)components/google_sheets/sources/new-comment/new-comment.mjs(1 hunks)components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs(1 hunks)components/google_sheets/sources/new-row-added/new-row-added.mjs(1 hunks)components/google_sheets/sources/new-updates/new-updates.mjs(1 hunks)components/google_sheets/sources/new-worksheet/new-worksheet.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (7)
components/google_sheets/sources/new-comment/new-comment.mjs (1)
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/google_sheets/sources/new-worksheet/new-worksheet.mjs (1)
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/google_sheets/actions/create-spreadsheet/create-spreadsheet.mjs (1)
Learnt from: jcortes
PR: #14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In components/gainsight_px/actions/create-account/create-account.mjs, the action name should be "Create Account" instead of "Create Memory".
components/google_sheets/package.json (1)
Learnt from: jcortes
PR: #14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like fs to package.json dependencies, as they are native modules provided by the Node.js runtime.
components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs (1)
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/google_sheets/sources/new-updates/new-updates.mjs (2)
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: #14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In components/the_magic_drip/sources/common.mjs, when processing items in getAndProcessData, savedIds is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/google_sheets/sources/new-row-added/new-row-added.mjs (1)
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
🔇 Additional comments (24)
components/google_sheets/google_sheets.app.mjs (2)
67-67: LGTM! Clean parameter addition with proper forwarding.The new
fetchOnlyOwnedparameter is correctly added to the destructured options and properly forwarded to thelistSheetsOptionsmethod.Also applies to: 70-70
256-262: LGTM! Proper implementation of ownership filtering.The implementation correctly:
- Updates the method signature to accept the
fetchOnlyOwnedparameter- Uses Google Drive API's ownership filter syntax
'me' in ownerswhen enabled- Maintains backward compatibility by making the parameter optional
components/google_sheets/sources/new-comment/new-comment.mjs (1)
9-9: LGTM! Appropriate version bump.The version increment is part of the coordinated release across Google Sheets components.
components/google_sheets/package.json (1)
3-3: LGTM! Appropriate package version increment.The version bump from 0.8.5 to 0.8.6 correctly reflects the addition of the new
fetchOnlyOwnedfeature following semantic versioning practices.components/google_sheets/actions/clear-rows/clear-rows.mjs (1)
10-10: LGTM! Coordinated version increment.The version bump maintains consistency across Google Sheets action components.
components/google_sheets/actions/insert-comment/insert-comment.mjs (1)
7-7: LGTM! Consistent version increment.The version bump aligns with the coordinated release across Google Sheets components.
components/google_sheets/actions/add-multiple-rows/add-multiple-rows.mjs (1)
14-14: Version bump acknowledged – no additional action requiredOnly the metadata string is updated from
0.2.12to0.2.13; no functional code was touched.components/google_sheets/actions/create-spreadsheet/create-spreadsheet.mjs (1)
7-7: Version increment confirmedThe change is confined to the component version (
0.1.11→0.1.12). Implementation remains intact.components/google_sheets/actions/get-cell/get-cell.mjs (1)
10-10: Component version updated correctlyNo logic altered; version string bumped to
0.1.12. All good.components/google_sheets/actions/delete-rows/delete-rows.mjs (1)
7-7: Version bump verifiedMetadata update to
0.0.10only, with no runtime impact.components/google_sheets/actions/update-cell/update-cell.mjs (1)
10-10: Version string adjustedBumped from
0.1.11to0.1.12; implementation unchanged.components/google_sheets/actions/copy-worksheet/copy-worksheet.mjs (1)
7-8: Version bump acknowledgedPatch increment to
0.1.10keeps semantic-versioning consistency with the other actions and reflects a non-breaking change.components/google_sheets/actions/delete-worksheet/delete-worksheet.mjs (1)
7-8: Patch version increment looks goodNo code-path changes; the
0.1.10bump aligns with the rest of the suite.components/google_sheets/actions/list-worksheets/list-worksheets.mjs (1)
7-8: Patch bump verified
0.1.10is consistent with the coordinated release across actions.components/google_sheets/actions/create-worksheet/create-worksheet.mjs (1)
7-8: ✅ Version update acceptedPatch bump only; no functional impact observed.
components/google_sheets/actions/add-column/add-column.mjs (1)
7-8: SemVer patch applied correctly
version: "0.1.10"keeps the action in lock-step with the package release.components/google_sheets/sources/new-worksheet/new-worksheet.mjs (1)
12-12: Version bump looks goodNo functional changes introduced here—just the metadata update.
components/google_sheets/actions/get-spreadsheet-by-id/get-spreadsheet-by-id.mjs (1)
7-7: Metadata-only increment – OKPure version update; behaviour remains unchanged.
components/google_sheets/actions/find-row/find-row.mjs (1)
10-10: Version update acknowledgedNo logic touched; safe to merge.
components/google_sheets/actions/insert-anchored-note/insert-anchored-note.mjs (1)
8-8: Just a patch-level bumpNothing else changed—looks fine.
components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs (1)
11-11: Patch version increment verifiedNo functional modifications detected.
components/google_sheets/actions/add-single-row/add-single-row.mjs (1)
13-13: Version bump looks correct – confirm CHANGELOG entryThe increment from
2.1.14→2.1.15is consistent with the rest of the PR. Just make sure the package-level CHANGELOG (if maintained) reflects the new version and notes the newfetchOnlyOwnedoption added in the app file so consumers can discover it.components/google_sheets/actions/update-multiple-rows/update-multiple-rows.mjs (1)
12-12: Minor version bump acknowledged
0.1.11→0.1.12is fine. No other changes in this file, so the bump just needs to be documented alongside the new Sheets option introduced in the app component.components/google_sheets/sources/new-updates/new-updates.mjs (1)
12-12: Source version increment noted
0.2.10→0.2.11aligns with the global component patch bump. Nothing else to flag.
WHY
Summary by CodeRabbit
New Features
Chores