-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New Components - salesforce_rest_api #17879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
WalkthroughThis update introduces several new Salesforce REST API actions and sources, primarily focused on cases, email messages, comments, knowledge articles, and email templates. It also adds or refactors common logic for instant and polling-based event sources, streamlining event handling and metadata extraction. Version numbers and import paths are updated accordingly. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Action
participant SalesforceAPI
User->>Action: Provide input (e.g., caseId, email, etc.)
Action->>SalesforceAPI: Construct and send SOQL/API request
SalesforceAPI-->>Action: Return queried or updated data
Action-->>User: Return result (record, summary, or response)
sequenceDiagram
participant Salesforce
participant Source
participant Webhook/Timer
participant User
Salesforce-->>Source: Record event (create/update)
Source->>Webhook/Timer: Emit event (webhook or polling)
Webhook/Timer-->>Source: Deliver event data
Source-->>User: Emit processed event with metadata
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. All modifications align with the objectives described in the linked issue. Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings
components/salesforce_rest_api/sources/knowledge-article-updated-instant/knowledge-article-updated-instant.mjs (5)Learnt from: GTFalcao Learnt from: GTFalcao Learnt from: GTFalcao Learnt from: GTFalcao Learnt from: GTFalcao 🔇 Additional comments (4)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
♻️ Duplicate comments (2)
components/salesforce_rest_api/actions/get-user/get-user.mjs (2)
24-24
: Potential SOQL injection vulnerabilitySame issue as in get-case.mjs - direct interpolation of user input into SOQL queries.
Consider using Salesforce's built-in record retrieval API or properly escape the input:
- let query = `SELECT ${fields.join(", ")} FROM User WHERE Id = '${this.userId}'`; + let query = `SELECT ${fields.join(", ")} FROM User WHERE Id = '${this.userId.replace(/'/g, "\\'")}'`;
31-32
: Fix typo and add error handlingSame issues as in get-case.mjs.
- $.export("$summary", `Sucessfully retrieved user with ID ${this.userId}`); - return records[0]; + if (records.length === 0) { + throw new Error(`No user found with ID ${this.userId}`); + } + $.export("$summary", `Successfully retrieved user with ID ${this.userId}`); + return records[0];
🧹 Nitpick comments (8)
components/salesforce_rest_api/actions/list-email-templates/list-email-templates.mjs (1)
20-20
: Fix typo in success message.There's a spelling error in the summary message.
- $.export("$summary", `Sucessfully retrieved ${records.length} email templates`); + $.export("$summary", `Successfully retrieved ${records.length} email templates`);components/salesforce_rest_api/actions/list-email-messages/list-email-messages.mjs (1)
35-35
: Fix typo in success message.There's a spelling error in the summary message.
- $.export("$summary", `Sucessfully retrieved ${records.length} email messages for case with ID ${this.caseId}`); + $.export("$summary", `Successfully retrieved ${records.length} email messages for case with ID ${this.caseId}`);components/salesforce_rest_api/actions/list-case-comments/list-case-comments.mjs (1)
29-29
: Fix typo in summary message.There's a spelling error: "Sucessfully" should be "Successfully".
- $.export("$summary", `Sucessfully retrieved ${records.length} comments for case with ID ${this.caseId}`); + $.export("$summary", `Successfully retrieved ${records.length} comments for case with ID ${this.caseId}`);components/salesforce_rest_api/actions/list-knowledge-articles/list-knowledge-articles.mjs (1)
20-20
: Fix typo in summary message.There's a spelling error: "Sucessfully" should be "Successfully".
- $.export("$summary", `Sucessfully retrieved ${records.length} knowledge articles`); + $.export("$summary", `Successfully retrieved ${records.length} knowledge articles`);components/salesforce_rest_api/actions/send-email/send-email.mjs (1)
29-29
: Fix typo: "time lines" → "timelines"- description: "Indicates whether to log the email on the specified records' activity time lines", + description: "Indicates whether to log the email on the specified records' activity timelines",components/salesforce_rest_api/sources/common/common-new-record.mjs (1)
41-41
: Fix typo in comment.- skipValidation: true, // neccessary for custom objects + skipValidation: true, // necessary for custom objectscomponents/salesforce_rest_api/sources/common/common-updated-record.mjs (2)
10-29
: Consider limiting historical events emission.The deploy hook emits up to 25 historical events. For sources with high activity, this could create noise during deployment. Consider making this configurable or documenting this behavior clearly.
43-43
: Fix typo in comment.- skipValidation: true, // neccessary for custom objects + skipValidation: true, // necessary for custom objects
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (21)
components/salesforce_rest_api/actions/get-case/get-case.mjs
(1 hunks)components/salesforce_rest_api/actions/get-user/get-user.mjs
(1 hunks)components/salesforce_rest_api/actions/list-case-comments/list-case-comments.mjs
(1 hunks)components/salesforce_rest_api/actions/list-email-messages/list-email-messages.mjs
(1 hunks)components/salesforce_rest_api/actions/list-email-templates/list-email-templates.mjs
(1 hunks)components/salesforce_rest_api/actions/list-knowledge-articles/list-knowledge-articles.mjs
(1 hunks)components/salesforce_rest_api/actions/send-email/send-email.mjs
(1 hunks)components/salesforce_rest_api/actions/update-email-template/update-email-template.mjs
(1 hunks)components/salesforce_rest_api/package.json
(1 hunks)components/salesforce_rest_api/sources/case-updated-instant/case-updated-instant.mjs
(1 hunks)components/salesforce_rest_api/sources/common/common-new-record.mjs
(1 hunks)components/salesforce_rest_api/sources/common/common-updated-record.mjs
(1 hunks)components/salesforce_rest_api/sources/common/common.mjs
(1 hunks)components/salesforce_rest_api/sources/email-template-updated-instant/email-template-updated-instant.mjs
(1 hunks)components/salesforce_rest_api/sources/knowledge-article-updated-instant/knowledge-article-updated-instant.mjs.mjs
(1 hunks)components/salesforce_rest_api/sources/new-case-instant/new-case-instant.mjs
(1 hunks)components/salesforce_rest_api/sources/new-email-template-instant/new-email-template-instant.mjs
(1 hunks)components/salesforce_rest_api/sources/new-knowledge-article-instant/new-knowledge-article-instant.mjs
(1 hunks)components/salesforce_rest_api/sources/new-record-instant/new-record-instant.mjs
(2 hunks)components/salesforce_rest_api/sources/record-deleted-instant/record-deleted-instant.mjs
(1 hunks)components/salesforce_rest_api/sources/record-updated-instant/record-updated-instant.mjs
(3 hunks)
🧰 Additional context used
🧠 Learnings (20)
components/salesforce_rest_api/package.json (1)
Learnt from: jcortes
PR: #14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like fs
to package.json
dependencies, as they are native modules provided by the Node.js runtime.
components/salesforce_rest_api/sources/common/common.mjs (4)
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The processTimerEvent
method in the components/salesforce_rest_api/sources/common.mjs
file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: jcortes
PR: #14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like fs
to package.json
dependencies, as they are native modules provided by the Node.js runtime.
components/salesforce_rest_api/sources/record-deleted-instant/record-deleted-instant.mjs (5)
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The processTimerEvent
method in the components/salesforce_rest_api/sources/common.mjs
file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: #14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In components/the_magic_drip/sources/common.mjs
, when processing items in getAndProcessData
, savedIds
is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/salesforce_rest_api/actions/list-email-templates/list-email-templates.mjs (4)
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Learnt from: GTFalcao
PR: #16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: The Salesloft API list endpoints (listPeople, listCadences, listUsers, listAccounts) return arrays directly in the response body, not wrapped in a metadata object with a nested data property. The _makeRequest method correctly returns response.data which contains the arrays that can be mapped over directly in propDefinitions.
components/salesforce_rest_api/actions/list-knowledge-articles/list-knowledge-articles.mjs (3)
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
components/salesforce_rest_api/sources/new-email-template-instant/new-email-template-instant.mjs (4)
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The processTimerEvent
method in the components/salesforce_rest_api/sources/common.mjs
file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
components/salesforce_rest_api/actions/update-email-template/update-email-template.mjs (3)
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: jcortes
PR: #14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In components/gainsight_px/actions/create-account/create-account.mjs
, the action name should be "Create Account" instead of "Create Memory".
components/salesforce_rest_api/actions/send-email/send-email.mjs (3)
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: jcortes
PR: #14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In components/gainsight_px/actions/create-account/create-account.mjs
, the action name should be "Create Account" instead of "Create Memory".
components/salesforce_rest_api/sources/new-case-instant/new-case-instant.mjs (2)
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The processTimerEvent
method in the components/salesforce_rest_api/sources/common.mjs
file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/salesforce_rest_api/actions/get-user/get-user.mjs (2)
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
components/salesforce_rest_api/sources/record-updated-instant/record-updated-instant.mjs (7)
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The processTimerEvent
method in the components/salesforce_rest_api/sources/common.mjs
file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In components/the_magic_drip/sources/common.mjs
, when processing items in getAndProcessData
, savedIds
is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: #16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: #17538
File: components/aircall/sources/new-sms/new-sms.mjs:19-25
Timestamp: 2025-07-09T18:07:12.426Z
Learning: In Aircall API webhook payloads, the created_at
field is returned as an ISO 8601 string format (e.g., "2020-02-18T20:52:22.000Z"), not as milliseconds since epoch. For Pipedream components, this needs to be converted to milliseconds using Date.parse()
before assigning to the ts
field in generateMeta()
.
components/salesforce_rest_api/sources/common/common-new-record.mjs (5)
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The processTimerEvent
method in the components/salesforce_rest_api/sources/common.mjs
file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In components/the_magic_drip/sources/common.mjs
, when processing items in getAndProcessData
, savedIds
is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/salesforce_rest_api/actions/list-email-messages/list-email-messages.mjs (3)
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
components/salesforce_rest_api/sources/case-updated-instant/case-updated-instant.mjs (3)
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The processTimerEvent
method in the components/salesforce_rest_api/sources/common.mjs
file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: #14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In components/the_magic_drip/sources/common.mjs
, when processing items in getAndProcessData
, savedIds
is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/salesforce_rest_api/actions/get-case/get-case.mjs (3)
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: jcortes
PR: #14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In components/gainsight_px/actions/create-account/create-account.mjs
, the action name should be "Create Account" instead of "Create Memory".
components/salesforce_rest_api/sources/email-template-updated-instant/email-template-updated-instant.mjs (5)
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The processTimerEvent
method in the components/salesforce_rest_api/sources/common.mjs
file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: #14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In components/the_magic_drip/sources/common.mjs
, when processing items in getAndProcessData
, savedIds
is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
components/salesforce_rest_api/sources/new-record-instant/new-record-instant.mjs (5)
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The processTimerEvent
method in the components/salesforce_rest_api/sources/common.mjs
file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In components/the_magic_drip/sources/common.mjs
, when processing items in getAndProcessData
, savedIds
is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/salesforce_rest_api/sources/knowledge-article-updated-instant/knowledge-article-updated-instant.mjs.mjs (5)
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The processTimerEvent
method in the components/salesforce_rest_api/sources/common.mjs
file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: #14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In components/the_magic_drip/sources/common.mjs
, when processing items in getAndProcessData
, savedIds
is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
components/salesforce_rest_api/sources/common/common-updated-record.mjs (6)
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The processTimerEvent
method in the components/salesforce_rest_api/sources/common.mjs
file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In components/the_magic_drip/sources/common.mjs
, when processing items in getAndProcessData
, savedIds
is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: #17538
File: components/aircall/sources/new-sms/new-sms.mjs:19-25
Timestamp: 2025-07-09T18:07:12.426Z
Learning: In Aircall API webhook payloads, the created_at
field is returned as an ISO 8601 string format (e.g., "2020-02-18T20:52:22.000Z"), not as milliseconds since epoch. For Pipedream components, this needs to be converted to milliseconds using Date.parse()
before assigning to the ts
field in generateMeta()
.
components/salesforce_rest_api/sources/new-knowledge-article-instant/new-knowledge-article-instant.mjs (4)
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The processTimerEvent
method in the components/salesforce_rest_api/sources/common.mjs
file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The common-webhook-methods.mjs
object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta
and getEventType
to enforce implementation in subclasses.
🧬 Code Graph Analysis (9)
components/salesforce_rest_api/actions/list-email-templates/list-email-templates.mjs (4)
components/salesforce_rest_api/actions/get-case/get-case.mjs (2)
fields
(24-24)query
(26-26)components/salesforce_rest_api/actions/update-email-template/update-email-template.mjs (1)
fields
(42-42)components/salesforce_rest_api/actions/list-email-messages/list-email-messages.mjs (2)
fields
(25-25)query
(26-26)components/salesforce_rest_api/actions/list-knowledge-articles/list-knowledge-articles.mjs (2)
fields
(13-13)query
(14-14)
components/salesforce_rest_api/actions/list-knowledge-articles/list-knowledge-articles.mjs (3)
components/salesforce_rest_api/actions/get-case/get-case.mjs (2)
fields
(24-24)query
(26-26)components/salesforce_rest_api/actions/list-email-messages/list-email-messages.mjs (2)
fields
(25-25)query
(26-26)components/salesforce_rest_api/actions/list-email-templates/list-email-templates.mjs (2)
fields
(13-13)query
(14-14)
components/salesforce_rest_api/actions/update-email-template/update-email-template.mjs (1)
components/salesforce_rest_api/actions/list-email-templates/list-email-templates.mjs (1)
fields
(13-13)
components/salesforce_rest_api/actions/get-user/get-user.mjs (3)
components/salesforce_rest_api/actions/get-case/get-case.mjs (2)
fields
(24-24)query
(26-26)components/salesforce_rest_api/actions/list-case-comments/list-case-comments.mjs (2)
fields
(22-22)query
(23-23)components/salesforce_rest_api/actions/list-email-messages/list-email-messages.mjs (2)
fields
(25-25)query
(26-26)
components/salesforce_rest_api/actions/list-case-comments/list-case-comments.mjs (3)
components/salesforce_rest_api/actions/get-case/get-case.mjs (2)
fields
(24-24)query
(26-26)components/salesforce_rest_api/actions/get-user/get-user.mjs (2)
fields
(22-22)query
(24-24)components/salesforce_rest_api/actions/list-email-messages/list-email-messages.mjs (2)
fields
(25-25)query
(26-26)
components/salesforce_rest_api/sources/common/common-new-record.mjs (4)
components/salesforce_rest_api/sources/common/common-updated-record.mjs (30)
objectType
(11-11)objectType
(16-16)objectType
(34-34)nameField
(12-12)nameField
(61-61)nameField
(68-68)ids
(17-17)object
(19-19)event
(20-25)event
(133-133)secretToken
(32-32)webhookData
(33-33)latestDateCovered
(50-50)latestDateCovered
(174-174)now
(52-52)fieldName
(158-158)entityType
(91-91)summary
(75-75)summary
(92-92)ts
(76-76)ts
(93-93)eventData
(153-156)emit
(144-151)columns
(159-159)columns
(193-193)events
(161-167)latestEvent
(169-171)meta
(26-26)meta
(136-136)meta
(182-182)components/salesforce_rest_api/sources/common/common.mjs (6)
nameField
(63-63)secretToken
(35-35)webhookData
(36-36)webhookData
(68-68)latestDateCovered
(52-52)now
(54-54)components/salesforce_rest_api/sources/record-deleted-instant/record-deleted-instant.mjs (10)
nameField
(14-14)item
(32-35)entityType
(21-21)entityType
(36-36)summary
(22-22)summary
(37-37)ts
(23-23)ts
(38-38)eventData
(49-52)meta
(66-66)components/salesforce_rest_api/sources/common/common-webhook-methods.mjs (3)
event
(40-40)secretToken
(36-36)meta
(41-41)
components/salesforce_rest_api/actions/list-email-messages/list-email-messages.mjs (5)
components/salesforce_rest_api/actions/get-case/get-case.mjs (2)
fields
(24-24)query
(26-26)components/salesforce_rest_api/actions/update-email-template/update-email-template.mjs (1)
fields
(42-42)components/salesforce_rest_api/actions/get-user/get-user.mjs (2)
fields
(22-22)query
(24-24)components/salesforce_rest_api/actions/list-case-comments/list-case-comments.mjs (2)
fields
(22-22)query
(23-23)components/salesforce_rest_api/actions/list-email-templates/list-email-templates.mjs (2)
fields
(13-13)query
(14-14)
components/salesforce_rest_api/actions/get-case/get-case.mjs (4)
components/salesforce_rest_api/actions/update-email-template/update-email-template.mjs (1)
fields
(42-42)components/salesforce_rest_api/actions/get-user/get-user.mjs (2)
fields
(22-22)query
(24-24)components/salesforce_rest_api/actions/list-case-comments/list-case-comments.mjs (2)
fields
(22-22)query
(23-23)components/salesforce_rest_api/actions/list-email-messages/list-email-messages.mjs (2)
fields
(25-25)query
(26-26)
components/salesforce_rest_api/sources/common/common-updated-record.mjs (3)
components/salesforce_rest_api/sources/common/common-new-record.mjs (25)
objectType
(10-10)objectType
(15-15)objectType
(32-32)nameField
(11-11)nameField
(59-59)nameField
(82-82)ids
(16-16)object
(18-18)event
(19-24)meta
(138-138)secretToken
(30-30)webhookData
(31-31)latestDateCovered
(48-48)latestDateCovered
(130-130)now
(50-50)summary
(73-73)summary
(89-89)ts
(74-74)ts
(90-90)entityType
(72-72)emit
(101-108)columns
(116-116)columns
(148-148)events
(118-123)getObjectTypeDescription
(150-150)components/salesforce_rest_api/sources/common/common.mjs (6)
nameField
(63-63)secretToken
(35-35)webhookData
(36-36)webhookData
(68-68)latestDateCovered
(52-52)now
(54-54)components/salesforce_rest_api/sources/common/common-webhook-methods.mjs (3)
event
(40-40)meta
(41-41)secretToken
(36-36)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Verify TypeScript components
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (23)
components/salesforce_rest_api/package.json (1)
3-3
: LGTM! Appropriate version bump for new features.The version bump from "1.6.1" to "1.7.0" correctly follows semantic versioning conventions for the addition of new Salesforce REST API components and functionality.
components/salesforce_rest_api/sources/common/common.mjs (1)
2-3
: LGTM! Import paths updated for directory restructuring.The import paths have been correctly updated to reflect the new directory structure, changing from relative paths with one level up (
../
) to two levels up (../../
).components/salesforce_rest_api/sources/record-deleted-instant/record-deleted-instant.mjs (2)
2-2
: LGTM! Import path updated for directory restructuring.The import path has been correctly updated to reference the restructured common module location.
10-10
: LGTM! Appropriate version bump.The version increment from "0.1.0" to "0.1.1" appropriately reflects the structural changes made to import paths.
components/salesforce_rest_api/actions/list-email-templates/list-email-templates.mjs (1)
13-22
: LGTM! Clean implementation following established patterns.The action correctly follows the established pattern of dynamically fetching field metadata and constructing SOQL queries, consistent with other similar actions in the codebase like
list-email-messages.mjs
andlist-knowledge-articles.mjs
.components/salesforce_rest_api/actions/list-email-messages/list-email-messages.mjs (1)
24-37
: LGTM! Well-implemented action with proper conditional filtering.The action correctly implements dynamic field retrieval and conditional SOQL query construction. The use of
RelatedToId
for filtering EmailMessage records by Case ID is appropriate, and the optional case ID parameter provides flexibility for querying all email messages or just those for a specific case.components/salesforce_rest_api/sources/email-template-updated-instant/email-template-updated-instant.mjs (1)
1-43
: LGTM! Consistent implementation follows established patterns.The source component correctly extends the common updated record module and implements the required
getObjectType()
method. The props configuration is consistent with other Salesforce source components, properly supporting both webhook and timer-based event delivery with optional field selection.components/salesforce_rest_api/sources/knowledge-article-updated-instant/knowledge-article-updated-instant.mjs.mjs (1)
1-43
: LGTM! Implementation is consistent with other source components.The source component correctly extends the common updated record module and properly implements the
getObjectType()
method for KnowledgeArticle objects. The structure and props are consistent with other Salesforce source components in this PR.components/salesforce_rest_api/actions/list-case-comments/list-case-comments.mjs (1)
1-32
: LGTM! Action follows consistent implementation pattern.The action correctly implements the dynamic field retrieval pattern and SOQL query construction that's consistent with other list actions in this PR. The use of
propDefinition
for case ID selection and the overall structure are well implemented.components/salesforce_rest_api/sources/case-updated-instant/case-updated-instant.mjs (1)
1-43
: LGTM! Consistent implementation follows established patterns.The source component correctly extends the common updated record module and implements the required
getObjectType()
method for Case objects. The implementation is consistent with other Salesforce source components in this PR.components/salesforce_rest_api/actions/list-knowledge-articles/list-knowledge-articles.mjs (1)
1-23
: LGTM! Action follows consistent implementation pattern.The action correctly implements the dynamic field retrieval pattern and SOQL query construction that's consistent with other list actions in this PR (as seen in
list-email-messages.mjs
andlist-email-templates.mjs
). The overall structure and implementation are well executed.components/salesforce_rest_api/sources/new-record-instant/new-record-instant.mjs (1)
1-30
: Clean refactoring to use common moduleThe refactoring successfully centralizes event handling logic in the common module while keeping the component focused on configuration.
components/salesforce_rest_api/sources/new-case-instant/new-case-instant.mjs (1)
1-43
: LGTM! Clean implementation following the established pattern.The component correctly extends the common new record module and properly configures all required properties for detecting new Salesforce Case records with both webhook and polling support.
components/salesforce_rest_api/sources/record-updated-instant/record-updated-instant.mjs (1)
1-34
: Good refactoring to reduce code duplication.The component has been successfully simplified by delegating all webhook and polling logic to the common updated record module. The dynamic object type handling via
this.objectType
is preserved correctly.components/salesforce_rest_api/actions/update-email-template/update-email-template.mjs (1)
57-81
: LGTM! Well-structured action implementation.The action correctly handles dynamic field generation and properly updates EmailTemplate records. The use of eslint comments to exclude internal properties from the update payload is appropriate.
components/salesforce_rest_api/sources/new-knowledge-article-instant/new-knowledge-article-instant.mjs (1)
1-43
: LGTM! Consistent implementation for Knowledge Article events.The component correctly implements the new record detection pattern for Knowledge Article objects, maintaining consistency with other Salesforce source components.
components/salesforce_rest_api/sources/common/common-updated-record.mjs (7)
1-8
: LGTM!The imports and module structure are properly organized, extending the common module appropriately.
84-99
: LGTM!The timer metadata generation is properly implemented with consistent ID generation and formatted summaries.
103-108
: Well-implemented field relevance check.The method correctly handles both filtered and unfiltered scenarios, using optional chaining for safe access.
109-131
: Effective change detection implementation.The method correctly identifies changed fields using JSON.stringify for deep comparison, which is appropriate for Salesforce API data that's already serialized.
132-142
: LGTM!The webhook event processing correctly filters relevant changes and enriches events with change details.
143-185
: Well-structured timer event processing.The implementation correctly handles pagination, maintains chronological order by reversing events, and properly updates the latest covered timestamp with second-precision normalization.
186-197
: LGTM!The timer activation hook properly initializes polling columns by fetching all available fields from the object description.
...rest_api/sources/knowledge-article-updated-instant/knowledge-article-updated-instant.mjs.mjs
Show resolved
Hide resolved
...onents/salesforce_rest_api/sources/new-email-template-instant/new-email-template-instant.mjs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927 lgtm! Ready for QA!
Resolves #17433
Summary by CodeRabbit