-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New Components - viewdns_info #17742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
WalkthroughThis update introduces a new ViewDNS.info integration, including a fully implemented API client with pagination support and six new action modules: Whois Lookup, Reverse Whois Lookup, Subdomain Discovery, Reverse IP Lookup, IP History, and DNS Record Lookup. The package metadata is also updated to reflect new dependencies and versioning. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Action
participant ViewDNSInfoApp
participant ViewDNS.info API
User->>Action: Trigger action (e.g., Whois Lookup)
Action->>ViewDNSInfoApp: Call endpoint method (e.g., whoisLookup)
ViewDNSInfoApp->>ViewDNS.info API: Send HTTP request with parameters
ViewDNS.info API-->>ViewDNSInfoApp: Return response data
ViewDNSInfoApp-->>Action: Return processed data (with pagination if needed)
Action-->>User: Output summary and results
Estimated code review effort4 (~90 minutes) Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/viewdns_info/actions/ip-history/ip-history.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/viewdns_info/viewdns_info.app.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/viewdns_info/actions/reverse-whois-lookup/reverse-whois-lookup.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (3)
components/viewdns_info/actions/whois-lookup/whois-lookup.mjs (1)
25-27
: Concise summary messageConsider including the queried domain in the exported summary for easier run-log scanning, e.g.
$.export("$summary", \
WHOIS information retrieved for ${this.domain}`);`components/viewdns_info/actions/reverse-ip-lookup/reverse-ip-lookup.mjs (1)
29-31
: Tiny UX tweakIncluding the queried host in the summary helps users understand what the count refers to:
-$.export("$summary", `Found ${results.length} domain${results.length === 1 ? "" : "s"} hosted on the IP address.`); +$.export("$summary", `Found ${results.length} domain${results.length === 1 ? "" : "s"} hosted on ${this.host}.`);components/viewdns_info/actions/reverse-whois-lookup/reverse-whois-lookup.mjs (1)
11-15
: Consider using a more descriptive property nameWhile 'q' might match the API parameter, consider using a more descriptive property name like
query
orsearchQuery
and mapping it to 'q' in the params. This would improve the user experience.- q: { + query: { type: "string", label: "Query", description: "The registrant name or email address to search for (e.g., [email protected]).", },And update the params:
params: { - q: this.q, + q: this.query, },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
components/viewdns_info/actions/dns-record-lookup/dns-record-lookup.mjs
(1 hunks)components/viewdns_info/actions/ip-history/ip-history.mjs
(1 hunks)components/viewdns_info/actions/reverse-ip-lookup/reverse-ip-lookup.mjs
(1 hunks)components/viewdns_info/actions/reverse-whois-lookup/reverse-whois-lookup.mjs
(1 hunks)components/viewdns_info/actions/subdomain-discovery/subdomain-discovery.mjs
(1 hunks)components/viewdns_info/actions/whois-lookup/whois-lookup.mjs
(1 hunks)components/viewdns_info/package.json
(2 hunks)components/viewdns_info/viewdns_info.app.mjs
(1 hunks)
🧠 Learnings (4)
components/viewdns_info/package.json (2)
Learnt from: jcortes
PR: #14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like fs
to package.json
dependencies, as they are native modules provided by the Node.js runtime.
Learnt from: js07
PR: #17375
File: components/zerobounce/actions/get-validation-results-file/get-validation-results-file.mjs:23-27
Timestamp: 2025-07-01T17:07:48.193Z
Learning: "dir" props in Pipedream components are hidden in the component form and not user-facing, so they don't require labels or descriptions for user clarity.
components/viewdns_info/actions/whois-lookup/whois-lookup.mjs (2)
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
components/viewdns_info/actions/subdomain-discovery/subdomain-discovery.mjs (2)
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
components/viewdns_info/viewdns_info.app.mjs (1)
Learnt from: GTFalcao
PR: #16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
🧬 Code Graph Analysis (7)
components/viewdns_info/actions/ip-history/ip-history.mjs (2)
components/viewdns_info/actions/dns-record-lookup/dns-record-lookup.mjs (1)
response
(24-30)components/viewdns_info/actions/whois-lookup/whois-lookup.mjs (1)
response
(18-23)
components/viewdns_info/actions/whois-lookup/whois-lookup.mjs (2)
components/viewdns_info/actions/dns-record-lookup/dns-record-lookup.mjs (1)
response
(24-30)components/viewdns_info/actions/ip-history/ip-history.mjs (1)
response
(18-23)
components/viewdns_info/actions/subdomain-discovery/subdomain-discovery.mjs (3)
components/viewdns_info/actions/reverse-ip-lookup/reverse-ip-lookup.mjs (1)
results
(18-27)components/viewdns_info/actions/reverse-whois-lookup/reverse-whois-lookup.mjs (1)
results
(18-27)components/viewdns_info/viewdns_info.app.mjs (1)
results
(88-88)
components/viewdns_info/actions/reverse-whois-lookup/reverse-whois-lookup.mjs (2)
components/viewdns_info/actions/reverse-ip-lookup/reverse-ip-lookup.mjs (1)
results
(18-27)components/viewdns_info/actions/subdomain-discovery/subdomain-discovery.mjs (1)
results
(18-27)
components/viewdns_info/actions/reverse-ip-lookup/reverse-ip-lookup.mjs (2)
components/viewdns_info/actions/reverse-whois-lookup/reverse-whois-lookup.mjs (1)
results
(18-27)components/viewdns_info/actions/subdomain-discovery/subdomain-discovery.mjs (1)
results
(18-27)
components/viewdns_info/actions/dns-record-lookup/dns-record-lookup.mjs (2)
components/viewdns_info/actions/ip-history/ip-history.mjs (1)
response
(18-23)components/viewdns_info/actions/whois-lookup/whois-lookup.mjs (1)
response
(18-23)
components/viewdns_info/viewdns_info.app.mjs (6)
components/viewdns_info/actions/dns-record-lookup/dns-record-lookup.mjs (1)
response
(24-30)components/viewdns_info/actions/ip-history/ip-history.mjs (1)
response
(18-23)components/viewdns_info/actions/whois-lookup/whois-lookup.mjs (1)
response
(18-23)components/viewdns_info/actions/reverse-ip-lookup/reverse-ip-lookup.mjs (1)
results
(18-27)components/viewdns_info/actions/reverse-whois-lookup/reverse-whois-lookup.mjs (1)
results
(18-27)components/viewdns_info/actions/subdomain-discovery/subdomain-discovery.mjs (1)
results
(18-27)
🧰 Additional context used
🧠 Learnings (4)
components/viewdns_info/package.json (2)
Learnt from: jcortes
PR: #14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like fs
to package.json
dependencies, as they are native modules provided by the Node.js runtime.
Learnt from: js07
PR: #17375
File: components/zerobounce/actions/get-validation-results-file/get-validation-results-file.mjs:23-27
Timestamp: 2025-07-01T17:07:48.193Z
Learning: "dir" props in Pipedream components are hidden in the component form and not user-facing, so they don't require labels or descriptions for user clarity.
components/viewdns_info/actions/whois-lookup/whois-lookup.mjs (2)
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
components/viewdns_info/actions/subdomain-discovery/subdomain-discovery.mjs (2)
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
Learnt from: GTFalcao
PR: #12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the run
method of an action, ensure the message is correctly formatted. For example, in the hackerone-get-members
action, the correct format is Successfully retrieved ${response.data.length} members
.
components/viewdns_info/viewdns_info.app.mjs (1)
Learnt from: GTFalcao
PR: #16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
🧬 Code Graph Analysis (7)
components/viewdns_info/actions/ip-history/ip-history.mjs (2)
components/viewdns_info/actions/dns-record-lookup/dns-record-lookup.mjs (1)
response
(24-30)components/viewdns_info/actions/whois-lookup/whois-lookup.mjs (1)
response
(18-23)
components/viewdns_info/actions/whois-lookup/whois-lookup.mjs (2)
components/viewdns_info/actions/dns-record-lookup/dns-record-lookup.mjs (1)
response
(24-30)components/viewdns_info/actions/ip-history/ip-history.mjs (1)
response
(18-23)
components/viewdns_info/actions/subdomain-discovery/subdomain-discovery.mjs (3)
components/viewdns_info/actions/reverse-ip-lookup/reverse-ip-lookup.mjs (1)
results
(18-27)components/viewdns_info/actions/reverse-whois-lookup/reverse-whois-lookup.mjs (1)
results
(18-27)components/viewdns_info/viewdns_info.app.mjs (1)
results
(88-88)
components/viewdns_info/actions/reverse-whois-lookup/reverse-whois-lookup.mjs (2)
components/viewdns_info/actions/reverse-ip-lookup/reverse-ip-lookup.mjs (1)
results
(18-27)components/viewdns_info/actions/subdomain-discovery/subdomain-discovery.mjs (1)
results
(18-27)
components/viewdns_info/actions/reverse-ip-lookup/reverse-ip-lookup.mjs (2)
components/viewdns_info/actions/reverse-whois-lookup/reverse-whois-lookup.mjs (1)
results
(18-27)components/viewdns_info/actions/subdomain-discovery/subdomain-discovery.mjs (1)
results
(18-27)
components/viewdns_info/actions/dns-record-lookup/dns-record-lookup.mjs (2)
components/viewdns_info/actions/ip-history/ip-history.mjs (1)
response
(18-23)components/viewdns_info/actions/whois-lookup/whois-lookup.mjs (1)
response
(18-23)
components/viewdns_info/viewdns_info.app.mjs (6)
components/viewdns_info/actions/dns-record-lookup/dns-record-lookup.mjs (1)
response
(24-30)components/viewdns_info/actions/ip-history/ip-history.mjs (1)
response
(18-23)components/viewdns_info/actions/whois-lookup/whois-lookup.mjs (1)
response
(18-23)components/viewdns_info/actions/reverse-ip-lookup/reverse-ip-lookup.mjs (1)
results
(18-27)components/viewdns_info/actions/reverse-whois-lookup/reverse-whois-lookup.mjs (1)
results
(18-27)components/viewdns_info/actions/subdomain-discovery/subdomain-discovery.mjs (1)
results
(18-27)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (3)
components/viewdns_info/package.json (1)
3-17
: LGTM – metadata looks correctVersion bump and new dependency are valid; no issues spotted.
components/viewdns_info/actions/ip-history/ip-history.mjs (1)
17-28
: All goodAction follows established pattern and exports a clear summary; nothing to add.
components/viewdns_info/actions/subdomain-discovery/subdomain-discovery.mjs (1)
1-35
: LGTM!The subdomain discovery action is well-implemented following the established patterns. The summary export correctly handles pluralization and follows the expected format.
Resolves #17571
Summary by CodeRabbit