-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[FIX] Snowflake - Insert Multiple Rows #17722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update introduces robust batch processing for inserting multiple rows into Snowflake. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant InsertMultipleRowsAction
participant SnowflakeApp
participant Utils
User->>InsertMultipleRowsAction: Trigger action with table, columns, values, batch options
InsertMultipleRowsAction->>Utils: Parse and validate input, create batches
InsertMultipleRowsAction->>SnowflakeApp: insertRows(table, columns, values, options)
SnowflakeApp->>Utils: estimatePayloadSize(values)
SnowflakeApp->>Utils: createBatches(values, batchSize)
loop For each batch
SnowflakeApp->>SnowflakeApp: _insertRowsOriginal(table, columns, batch)
SnowflakeApp-->>InsertMultipleRowsAction: Batch result (success/failure)
end
InsertMultipleRowsAction->>User: Export summary and results
Estimated code review effort3 (~45 minutes) Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/snowflake/actions/execute-sql-query/execute-sql-query.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/snowflake/actions/insert-multiple-rows/insert-multiple-rows.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/snowflake/snowflake.app.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (20)
✅ Files skipped from review due to trivial changes (15)
🚧 Files skipped from review as they are similar to previous changes (3)
🧰 Additional context used🧬 Code Graph Analysis (2)components/snowflake/actions/insert-multiple-rows/insert-multiple-rows.mjs (1)
components/snowflake/snowflake.app.mjs (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (13)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
4018d2d
to
0465cb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
WHY
Resolves #17239
Summary by CodeRabbit
New Features
Bug Fixes
Chores