[FEATURE] Shopify Developer App - updates #15943
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis pull request primarily updates version numbers in numerous Shopify Developer App modules while making minor adjustments. Several action files now include enhanced error handling by checking for user errors within API responses before proceeding. Additionally, the GraphQL queries have been modified by removing the pagination parameter for metafields, and specific property names have been updated in source modules to reflect newer naming conventions. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Action
participant API
Caller->>Action: Execute run() method
Action->>API: Initiate API request
API-->>Action: Return response (data & userErrors)
alt userErrors present
Action->>Action: Check errors and throw first error message
else No errors
Action->>Caller: Return successful response
end
Assessment against linked issues
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
components/shopify_developer_app/actions/update-product/update-product.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (5)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
components/shopify_developer_app/actions/update-product-variant/update-product-variant.mjs (1)
14-14: Version Increment & Property Adjustment in Update Product VariantThe version has been bumped to "0.0.8", and the removal of the
variantsproperty (as described) should be cross-checked with any dependent logic. Additionally, the enhanced error handling introduced in this module is a positive improvement. Make sure that any references to thevariantsproperty in other parts of the code are updated accordingly.components/shopify_developer_app/actions/search-custom-collection-by-name/search-custom-collection-by-name.mjs (1)
19-20: Consider standardizing property naming convention.While this file keeps using the property name
shopify, other components likeproduct-added-to-custom-collection.mjshave renamed this property toapp. Consider standardizing this naming convention across all components for better consistency.props: { - shopify, + app: shopify, ...props, },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (53)
components/shopify_developer_app/actions/add-product-to-custom-collection/add-product-to-custom-collection.mjs(1 hunks)components/shopify_developer_app/actions/add-tags/add-tags.mjs(1 hunks)components/shopify_developer_app/actions/create-article/create-article.mjs(1 hunks)components/shopify_developer_app/actions/create-blog/create-blog.mjs(1 hunks)components/shopify_developer_app/actions/create-custom-collection/create-custom-collection.mjs(1 hunks)components/shopify_developer_app/actions/create-customer/create-customer.mjs(2 hunks)components/shopify_developer_app/actions/create-metafield/create-metafield.mjs(1 hunks)components/shopify_developer_app/actions/create-metaobject/create-metaobject.mjs(1 hunks)components/shopify_developer_app/actions/create-order/create-order.mjs(2 hunks)components/shopify_developer_app/actions/create-page/create-page.mjs(1 hunks)components/shopify_developer_app/actions/create-product-variant/create-product-variant.mjs(1 hunks)components/shopify_developer_app/actions/create-product/create-product.mjs(1 hunks)components/shopify_developer_app/actions/create-smart-collection/create-smart-collection.mjs(1 hunks)components/shopify_developer_app/actions/delete-article/delete-article.mjs(1 hunks)components/shopify_developer_app/actions/delete-blog/delete-blog.mjs(1 hunks)components/shopify_developer_app/actions/delete-metafield/delete-metafield.mjs(1 hunks)components/shopify_developer_app/actions/delete-page/delete-page.mjs(1 hunks)components/shopify_developer_app/actions/get-articles/get-articles.mjs(1 hunks)components/shopify_developer_app/actions/get-metafields/get-metafields.mjs(1 hunks)components/shopify_developer_app/actions/get-metaobjects/get-metaobjects.mjs(1 hunks)components/shopify_developer_app/actions/get-order/get-order.mjs(1 hunks)components/shopify_developer_app/actions/get-pages/get-pages.mjs(1 hunks)components/shopify_developer_app/actions/search-custom-collection-by-name/search-custom-collection-by-name.mjs(1 hunks)components/shopify_developer_app/actions/search-customers/search-customers.mjs(1 hunks)components/shopify_developer_app/actions/search-product-variant/search-product-variant.mjs(1 hunks)components/shopify_developer_app/actions/search-products/search-products.mjs(1 hunks)components/shopify_developer_app/actions/update-article/update-article.mjs(1 hunks)components/shopify_developer_app/actions/update-customer/update-customer.mjs(2 hunks)components/shopify_developer_app/actions/update-inventory-level/update-inventory-level.mjs(1 hunks)components/shopify_developer_app/actions/update-metafield/update-metafield.mjs(1 hunks)components/shopify_developer_app/actions/update-metaobject/update-metaobject.mjs(1 hunks)components/shopify_developer_app/actions/update-page/update-page.mjs(1 hunks)components/shopify_developer_app/actions/update-product-variant/update-product-variant.mjs(1 hunks)components/shopify_developer_app/actions/update-product/update-product.mjs(2 hunks)components/shopify_developer_app/common/queries.mjs(3 hunks)components/shopify_developer_app/package.json(1 hunks)components/shopify_developer_app/sources/new-abandoned-cart/new-abandoned-cart.mjs(1 hunks)components/shopify_developer_app/sources/new-article/new-article.mjs(1 hunks)components/shopify_developer_app/sources/new-cancelled-order/new-cancelled-order.mjs(1 hunks)components/shopify_developer_app/sources/new-customer-created/new-customer-created.mjs(1 hunks)components/shopify_developer_app/sources/new-draft-order/new-draft-order.mjs(1 hunks)components/shopify_developer_app/sources/new-event-emitted/new-event-emitted.mjs(1 hunks)components/shopify_developer_app/sources/new-fulfillment-event/new-fulfillment-event.mjs(1 hunks)components/shopify_developer_app/sources/new-order-created/new-order-created.mjs(1 hunks)components/shopify_developer_app/sources/new-order-fulfilled/new-order-fulfilled.mjs(1 hunks)components/shopify_developer_app/sources/new-page/new-page.mjs(1 hunks)components/shopify_developer_app/sources/new-paid-order/new-paid-order.mjs(1 hunks)components/shopify_developer_app/sources/new-product-created/new-product-created.mjs(1 hunks)components/shopify_developer_app/sources/new-product-updated/new-product-updated.mjs(2 hunks)components/shopify_developer_app/sources/new-refund-created/new-refund-created.mjs(2 hunks)components/shopify_developer_app/sources/new-updated-customer/new-updated-customer.mjs(1 hunks)components/shopify_developer_app/sources/new-updated-order/new-updated-order.mjs(1 hunks)components/shopify_developer_app/sources/product-added-to-custom-collection/product-added-to-custom-collection.mjs(1 hunks)
🔇 Additional comments (70)
components/shopify_developer_app/sources/new-abandoned-cart/new-abandoned-cart.mjs (1)
14-14: Version updated appropriately.Version bump from "0.0.6" to "0.0.7" aligns with the coordinated versioning update across multiple Shopify Developer App modules in this PR.
components/shopify_developer_app/sources/new-page/new-page.mjs (1)
14-14: Version updated appropriately.Version bump from "0.0.5" to "0.0.6" is consistent with the versioning updates being applied across multiple modules in this PR.
components/shopify_developer_app/sources/new-refund-created/new-refund-created.mjs (2)
8-8: Version updated appropriately.Version bump from "0.0.6" to "0.0.7" is consistent with the versioning updates being applied across multiple modules in this PR.
17-17: Property name corrected to match API response format.Good change from camelCase
createdAtto snake_casecreated_at, which aligns with Shopify's API response format for timestamps. This ensures proper timestamp parsing for event metadata generation.components/shopify_developer_app/sources/new-fulfillment-event/new-fulfillment-event.mjs (2)
9-9: Version updated appropriately.Version bump from "0.0.7" to "0.0.8" is consistent with the versioning updates being applied across multiple modules in this PR.
17-17: Property name corrected to match API response format.Good change from camelCase
updatedAtto snake_caseupdated_at, which aligns with Shopify's API response format for timestamps. This ensures proper timestamp parsing for event metadata generation and is consistent with similar changes in other files.components/shopify_developer_app/sources/new-product-created/new-product-created.mjs (2)
9-9: Version number increment correctly applied.The version number has been correctly updated from "0.0.9" to "0.0.10" to reflect the changes made in this update.
17-17: Property name updated to match Shopify API format.The property name has been changed from
createdAt(camelCase) tocreated_at(snake_case), which correctly aligns with Shopify's REST API response format. This ensures proper timestamp parsing.components/shopify_developer_app/sources/new-draft-order/new-draft-order.mjs (2)
9-9: Version number increment correctly applied.The version number has been properly updated from "0.0.9" to "0.0.10" to reflect the changes made in this update.
17-17: Property name updated to match Shopify API format.The property name has been changed from
createdAt(camelCase) tocreated_at(snake_case), which correctly aligns with Shopify's REST API response format. This ensures proper timestamp parsing.components/shopify_developer_app/sources/new-paid-order/new-paid-order.mjs (2)
9-9: Version number increment correctly applied.The version number has been properly updated from "0.0.9" to "0.0.10" to reflect the changes made in this update.
17-17: Property name updated to match Shopify API format.The property name has been changed from
updatedAt(camelCase) toupdated_at(snake_case), which correctly aligns with Shopify's REST API response format. This ensures proper timestamp parsing for paid order events.components/shopify_developer_app/sources/new-customer-created/new-customer-created.mjs (2)
9-9: Version number increment correctly applied.The version number has been properly updated from "0.0.9" to "0.0.10" to reflect the changes made in this update.
17-17: Property name updated to match Shopify API format.The property name has been changed from
createdAt(camelCase) tocreated_at(snake_case), which correctly aligns with Shopify's REST API response format. This ensures proper timestamp parsing.components/shopify_developer_app/sources/new-cancelled-order/new-cancelled-order.mjs (2)
9-9: Version update for consistencyThe version has been correctly incremented from 0.0.9 to 0.0.10, maintaining consistency with other Shopify Developer App modules in this PR.
17-17: Property name updated to match Shopify's API response formatChanged from
updatedAttoupdated_atto properly match Shopify's API response format which uses snake_case rather than camelCase for property names.components/shopify_developer_app/sources/new-updated-order/new-updated-order.mjs (2)
9-9: Version update for consistencyThe version has been correctly incremented from 0.0.9 to 0.0.10, maintaining consistency with other Shopify Developer App modules in this PR.
17-17: Property name updated to match Shopify's API response formatChanged from
updatedAttoupdated_atto properly match Shopify's API response format which uses snake_case rather than camelCase for property names.components/shopify_developer_app/sources/new-order-fulfilled/new-order-fulfilled.mjs (2)
9-9: Version update for consistencyThe version has been correctly incremented from 0.0.6 to 0.0.7, maintaining consistency with the versioning pattern of other Shopify Developer App modules in this PR.
17-17: Property name updated to match Shopify's API response formatChanged from
updatedAttoupdated_atto properly match Shopify's API response format which uses snake_case rather than camelCase for property names.components/shopify_developer_app/sources/new-updated-customer/new-updated-customer.mjs (2)
9-9: Version update for consistencyThe version has been correctly incremented from 0.0.9 to 0.0.10, maintaining consistency with other Shopify Developer App modules in this PR.
17-17: Property name updated to match Shopify's API response formatChanged from
updatedAttoupdated_atto properly match Shopify's API response format which uses snake_case rather than camelCase for property names.components/shopify_developer_app/common/queries.mjs (1)
112-112:❓ Verification inconclusive
Pagination parameter removed from metafields query
You've removed the
afterparameter from the metafields query in the LIST_ORDERS GraphQL query. This change affects pagination capabilities, limiting the metafields retrieval to only the first batch specified by$firstwithout the ability to fetch subsequent pages.If this is intentional (perhaps due to API changes or performance considerations), please ensure that:
- The implementation that consumes this query is updated accordingly
- There's proper handling in case the number of metafields exceeds the limit set by
$first
🏁 Script executed:
#!/bin/bash # Check if there are any references to metafield pagination in the codebase echo "Checking for metafield pagination usage..." rg -i "metafields.*after" --type js components/shopify_developer_app/Length of output: 166
Action Required: Verify Consumer Impact of Removed Pagination Parameter
The shell search for references to a pagination “after” parameter in the
shopify_developer_appcomponent did not return any results. However, since the output is inconclusive, please manually verify that the removal of theafterparameter from the metafields query incomponents/shopify_developer_app/common/queries.mjswas intentional and that the consuming implementation has been updated accordingly. In particular:
- Confirm that no downstream code assumes pagination support beyond the initial
$firstbatch.- Verify that there’s proper handling in cases where the total number of metafields exceeds the limit specified by
$first.components/shopify_developer_app/sources/new-order-created/new-order-created.mjs (2)
9-9: Version number incremented appropriatelyVersion bump from 0.0.9 to 0.0.10 is appropriate for the changes made in this file.
17-17: Property name updated to match Shopify API formatYou've updated the property name from
createdAttocreated_at, which aligns with Shopify's API response format. This change fixes a potential bug where timestamp information wouldn't be properly accessed.components/shopify_developer_app/package.json (1)
3-3: Package version updated correctlyThe version increment from 0.7.0 to 0.7.1 follows semantic versioning principles for minor changes, which is appropriate for the modifications made across the component files.
components/shopify_developer_app/actions/get-articles/get-articles.mjs (1)
14-14: Version number incremented appropriatelyVersion bump from 0.0.7 to 0.0.8 is consistent with the versioning updates throughout the PR.
components/shopify_developer_app/actions/get-pages/get-pages.mjs (1)
14-14: Version Number Update:
The version string has been updated to"0.0.8", which aligns consistently with the coordinated release effort across similar modules in the Shopify Developer App.components/shopify_developer_app/actions/delete-page/delete-page.mjs (1)
14-14: Version Number Update:
The version has been incremented to"0.0.8", reflecting the standardized versioning across related actions. No further changes are needed.components/shopify_developer_app/actions/create-article/create-article.mjs (1)
14-14: Version Number Update:
The updated version"0.0.8"is consistent with the recent changes across similar modules. This update is straightforward and well executed.components/shopify_developer_app/actions/update-metaobject/update-metaobject.mjs (1)
14-14: Version Number Update:
The version is updated to"0.0.9", reflecting an incremental change compared to the previous"0.0.8". This consistency in version management is commendable.components/shopify_developer_app/actions/delete-article/delete-article.mjs (1)
14-14: Version Number Update:
The export’s version has been updated to"0.0.8", ensuring parity with other deletion-related modules in the app. The update is minimal and appropriate.components/shopify_developer_app/actions/get-order/get-order.mjs (1)
8-8: Version Bump Confirmation
The version is updated to"0.0.4", which aligns with the coordinated versioning strategy across the Shopify Developer App modules. Please verify that this update is intentional and consistent with your release process.components/shopify_developer_app/actions/create-product-variant/create-product-variant.mjs (1)
14-14: Version Update Verification
The version has been updated to"0.0.7". Ensure that any downstream integrations referencing this module are updated accordingly.components/shopify_developer_app/actions/search-customers/search-customers.mjs (1)
7-7: Consistent Version Increment
The version is now set to"0.0.6", in keeping with the other modules in the project. This change appears straightforward—please confirm that no other logic was meant to be adjusted.components/shopify_developer_app/actions/create-metaobject/create-metaobject.mjs (1)
14-14: Version Number Update
The exported version is now"0.0.8". This update is in line with the overall module versioning approach. Just double-check that any documentation referencing the old version is updated, if applicable.components/shopify_developer_app/actions/add-tags/add-tags.mjs (1)
14-14: Version Increment Confirmation
The version has been incremented to"0.0.6", matching the scheme used in related modules. Everything looks consistent with the PR objectives regarding version updates.components/shopify_developer_app/actions/create-blog/create-blog.mjs (1)
14-14: Version Update Validated.
The version number has been correctly updated to"0.0.8"in this module, which is consistent with the coordinated version bump across related Shopify Developer App actions.components/shopify_developer_app/actions/delete-blog/delete-blog.mjs (1)
14-14: Version Update Confirmed.
The export’s version has been incremented to"0.0.8", ensuring consistency with similar modules in the PR.components/shopify_developer_app/sources/new-event-emitted/new-event-emitted.mjs (1)
10-10: Version Increment Verified.
The source module’s version has been updated to"0.0.11", aligning with the overall versioning strategy applied in this update.components/shopify_developer_app/actions/create-product/create-product.mjs (1)
14-14: Proper Version Bump.
The module version has been increased to"0.0.6", which is in line with the standardized updates across other product-related actions.components/shopify_developer_app/actions/update-page/update-page.mjs (1)
14-14: Version Update Verified.
The updated version"0.0.8"is correctly applied here, matching the versioning updates seen in other similar modules of the Shopify Developer App.components/shopify_developer_app/actions/create-page/create-page.mjs (1)
14-14: Version Update: Create-Page Action.
The version has been updated to"0.0.8", which is in line with the coordinated release bump across similar modules. No functional changes are present here.components/shopify_developer_app/actions/update-article/update-article.mjs (1)
14-14: Version Update: Update-Article Action.
The version number is updated to"0.0.8"—a straightforward version bump that ensures consistency with the overall release cycle for the Shopify Developer App.components/shopify_developer_app/actions/get-metaobjects/get-metaobjects.mjs (1)
14-14: Version Update: Get-Metaobjects Action.
The version number has been incremented to"0.0.7". This change is simple and consistent with similar version updates in the project.components/shopify_developer_app/sources/new-article/new-article.mjs (1)
14-14: Version Update: New-Article Source.
The version is now set to"0.0.6", matching the new release cycle as implemented in other related modules. This maintains consistency across the codebase.components/shopify_developer_app/actions/delete-metafield/delete-metafield.mjs (1)
12-12: Version Update: Delete-Metafield Action.
The version number has been bumped to"0.0.7". The update is straightforward and aligns well with the coordinated version changes observed across other modules in this PR.components/shopify_developer_app/actions/get-metafields/get-metafields.mjs (1)
11-11: Version Update Verification in Get Metafields ModuleThe version update to "0.0.7" is correctly applied. Since this change is purely for versioning, ensure that any downstream integrations or consumers are informed, though no functional changes are introduced here.
components/shopify_developer_app/actions/create-custom-collection/create-custom-collection.mjs (1)
14-14: Version Bump Confirmation in Create Custom CollectionThe version number has been updated to "0.0.6" as expected. The change is isolated to versioning without affecting the behavior or structure of the module, maintaining consistency with the coordinated update strategy.
components/shopify_developer_app/actions/search-product-variant/search-product-variant.mjs (1)
14-14: Consistent Version Update in Search Product Variant ModuleThe version update to "0.0.6" is consistently applied. The changes are isolated to versioning and do not affect the overall functionality of the module.
components/shopify_developer_app/actions/update-inventory-level/update-inventory-level.mjs (1)
14-14: Unified Version Bump in Update Inventory Level ModuleThe version change to "0.0.6" aligns with the coordinated update strategy across the Shopify Developer App modules. No additional modifications or logic changes are present here, ensuring smooth integration.
components/shopify_developer_app/actions/update-metafield/update-metafield.mjs (1)
12-12: Version Bump Verification for update-metafield.mjs
The version update from the previous version to"0.0.7"is appropriately applied here. This change is purely cosmetic and aligns with the coordinated version upgrades across the Shopify Developer App modules.components/shopify_developer_app/actions/add-product-to-custom-collection/add-product-to-custom-collection.mjs (1)
14-14: Version Increment Update to "0.0.6"
The version bump in this file is correctly updated and consistent with the overall release cycle. No functionality is affected by this change.components/shopify_developer_app/actions/search-products/search-products.mjs (1)
14-14: Simple Version Upgrade to "0.0.6"
This update is a straightforward version change with no impact on the underlying logic. The change maintains consistency across similar modules.components/shopify_developer_app/actions/create-smart-collection/create-smart-collection.mjs (1)
14-14: Version Update to "0.0.6" Maintained
The version bump here follows the established pattern seen in other modules in this PR. There are no additional modifications to functionality, so the update is safe and clear.components/shopify_developer_app/actions/create-metafield/create-metafield.mjs (1)
13-13: Version Bump to "0.0.7" Confirmed
The version increment from"0.0.6"to"0.0.7"is correctly applied. This change does not affect the logic or operation of the module and adheres to the coordinated versioning strategy across the project.components/shopify_developer_app/sources/product-added-to-custom-collection/product-added-to-custom-collection.mjs (2)
14-14: Version update looks good.Properly incremented version number from "0.0.5" to "0.0.6", which is consistent with version updates across other Shopify Developer App components.
19-19: Property name change fromshopifytoappis appropriate.This change reflects a move toward more generic naming conventions, making the code more maintainable. This abstraction decouples the component interface from specific implementation details.
components/shopify_developer_app/actions/search-custom-collection-by-name/search-custom-collection-by-name.mjs (1)
14-14: Version update looks good.Properly incremented version number from "0.0.5" to "0.0.6" as part of the coordinated version bump across Shopify Developer App components.
components/shopify_developer_app/sources/new-product-updated/new-product-updated.mjs (2)
8-8: Version update looks good.Version increment from "0.0.7" to "0.0.8" follows the coordinated versioning strategy for Shopify Developer App components, though with a different version sequence.
46-46: Property name change improves API compatibility.Changing from
resource.updatedAttoresource.updated_ataligns with Shopify API's snake_case naming convention, fixing a potential bug where the code was trying to access a non-existent property due to incorrect casing.components/shopify_developer_app/actions/create-order/create-order.mjs (2)
8-8: Version update looks good.Properly incremented version number from "0.0.5" to "0.0.6" as part of the coordinated version bump across Shopify Developer App components.
157-159: Excellent addition of error handling.This change greatly improves the robustness of the code by checking for user errors in the API response. Throwing an error with the specific message from the API response provides better feedback for debugging and prevents silent failures.
components/shopify_developer_app/actions/update-customer/update-customer.mjs (2)
9-9: Version number updated appropriately.Version has been incremented from 0.0.6 to 0.0.7, reflecting the changes in this PR.
110-112: Great addition of error handling.Adding explicit error handling for Shopify's user errors improves the component's reliability. This change ensures that API-level validation errors are properly surfaced to the user rather than being silently ignored.
components/shopify_developer_app/actions/create-customer/create-customer.mjs (2)
7-7: Version number updated appropriately.Version has been incremented from 0.0.5 to 0.0.6, reflecting the changes in this PR.
91-93: Great addition of error handling.Adding explicit error handling for Shopify's user errors improves the component's reliability. This ensures that API-level validation errors are properly surfaced to the user rather than proceeding with potentially invalid data.
components/shopify_developer_app/actions/update-product/update-product.mjs (3)
10-10: Version number updated appropriately.Version has been incremented from 0.0.6 to 0.0.7, reflecting the changes in this PR.
104-104: Explicit product ID assignment improvement.Adding the explicit
idfield to the input object ensures the correct product is targeted for updates. This is a good practice for clarity and prevents potential issues.
119-122: Enhanced error handling and improved success message.This change adds proper error handling for Shopify's user errors and improves the success message to include both the product title and ID. This makes debugging and user feedback more effective.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/shopify_developer_app/actions/update-product/update-product.mjs(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Publish TypeScript components
- GitHub Check: pnpm publish
- GitHub Check: Verify TypeScript components
🔇 Additional comments (4)
components/shopify_developer_app/actions/update-product/update-product.mjs (4)
128-132: Good improvement in error handling.The enhanced error handling is a positive change. Now the code properly checks for user errors in the API response before proceeding, which will provide better feedback to users when something goes wrong.
9-9: Version increment looks good.The version update from 0.0.6 to 0.0.7 is appropriate given the changes in functionality.
95-107: Improved argument structure.The updated structure with explicit ID specification is cleaner and more direct. This change improves the clarity of what's being passed to the API.
121-126:❓ Verification inconclusive
Verify media property usage.
The property is named
imagesin the props (line 54), but assigned toargs.mediahere. Double-check that this is the expected behavior for the Shopify API.
🏁 Script executed:
#!/bin/bash # Search for other usages of images/media to understand the expected pattern echo "Searching for other image handling patterns in Shopify components..." rg -A 3 "args.media" --type js components/shopify_developer_app/ echo "Checking Shopify GraphQL docs references..." rg -A 3 "mediaContentType" --type js components/shopify_developer_app/Length of output: 379
Attention: Confirm Shopify API Field Mapping
The current implementation transforms the component’s
imagesprop into anargs.mediaarray—with each image being wrapped in an object containingoriginalSourceand a hardcodedmediaContentType: "IMAGE". Our initial repository search did not reveal alternative usages ofargs.mediaor any patterns that would clarify its intended usage. This makes it important to verify manually that the Shopify API indeed expects a field namedmedia(with this precise structure) rather than directly using theimagesproperty.Please double-check the Shopify API documentation to ensure:
- The API requires a parameter named
mediafor updating product images.- Each media object should have a structure like
{ originalSource, mediaContentType: "IMAGE" }.If the documentation indicates a different field name or structure (for instance, if the API expects
imagesrather thanmedia), kindly update the mapping accordingly.
components/shopify_developer_app/actions/update-product/update-product.mjs
Show resolved
Hide resolved
|
/approve |
Resolves #15914
Summary by CodeRabbit
Chores
Bug Fixes
Refactor