-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Microsoft Components #15443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft Components #15443
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis pull request introduces several new actions and updates to Microsoft components across OneDrive, Outlook, and Outlook Calendar. The changes include new functionality for retrieving files, managing email labels, listing calendar events, and retrieving free/busy schedules. Additionally, version updates and platform dependency upgrades have been made to the respective package.json files. Changes
Assessment against linked issues
Suggested Labels
Suggested Reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 9
🧹 Nitpick comments (2)
components/microsoft_onedrive/actions/get-file-by-id/get-file-by-id.mjs (1)
22-22
: Fix typo in success message.The word "retreived" is misspelled in the success message.
- $.export("$summary", `Successfully retreived file with ID: ${this.fileId}`); + $.export("$summary", `Successfully retrieved file with ID: ${this.fileId}`);components/microsoft_outlook/actions/remove-label-from-email/remove-label-from-email.mjs (1)
30-35
: Remove debug console.log statements.Debug console.log statements should be removed from production code.
- let labels = message?.categories; console.log(labels); + let labels = message?.categories || []; - const index = labels.indexOf(this.labelId); console.log(index); + const index = labels.indexOf(this.labelId); if (index > -1) { - labels.splice(index, 1); console.log(labels); + labels.splice(index, 1); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (18)
components/microsoft_onedrive/actions/get-file-by-id/get-file-by-id.mjs
(1 hunks)components/microsoft_onedrive/package.json
(2 hunks)components/microsoft_outlook/actions/add-label-to-email/add-label-to-email.mjs
(1 hunks)components/microsoft_outlook/actions/create-contact/create-contact.mjs
(1 hunks)components/microsoft_outlook/actions/create-draft-email/create-draft-email.mjs
(1 hunks)components/microsoft_outlook/actions/find-contacts/find-contacts.mjs
(1 hunks)components/microsoft_outlook/actions/list-contacts/list-contacts.mjs
(1 hunks)components/microsoft_outlook/actions/list-labels/list-labels.mjs
(1 hunks)components/microsoft_outlook/actions/remove-label-from-email/remove-label-from-email.mjs
(1 hunks)components/microsoft_outlook/actions/send-email/send-email.mjs
(1 hunks)components/microsoft_outlook/actions/update-contact/update-contact.mjs
(1 hunks)components/microsoft_outlook/microsoft_outlook.app.mjs
(2 hunks)components/microsoft_outlook/package.json
(2 hunks)components/microsoft_outlook/sources/new-contact/new-contact.mjs
(1 hunks)components/microsoft_outlook/sources/new-email/new-email.mjs
(1 hunks)components/microsoft_outlook_calendar/actions/get-schedule/get-schedule.mjs
(1 hunks)components/microsoft_outlook_calendar/actions/list-events/list-events.mjs
(1 hunks)components/microsoft_outlook_calendar/package.json
(2 hunks)
✅ Files skipped from review due to trivial changes (8)
- components/microsoft_outlook/actions/send-email/send-email.mjs
- components/microsoft_outlook/actions/update-contact/update-contact.mjs
- components/microsoft_outlook/actions/create-draft-email/create-draft-email.mjs
- components/microsoft_outlook/actions/find-contacts/find-contacts.mjs
- components/microsoft_outlook/actions/create-contact/create-contact.mjs
- components/microsoft_outlook/actions/list-contacts/list-contacts.mjs
- components/microsoft_outlook/sources/new-contact/new-contact.mjs
- components/microsoft_outlook/sources/new-email/new-email.mjs
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Verify TypeScript components
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (5)
components/microsoft_outlook_calendar/package.json (1)
3-3
: Verify compatibility with the updated platform dependency.The major version bump of @pipedream/platform from ^1.5.1 to ^3.0.3 might introduce breaking changes. Please ensure all platform API usage is compatible with version 3.x.
Also applies to: 18-18
components/microsoft_onedrive/package.json (2)
3-3
: Version bump follows semver correctly.The version increase from 1.5.2 to 1.6.0 appropriately reflects the addition of new features mentioned in the PR summary.
13-13
: Verify compatibility with @pipedream/platform v3.x.xThe major version jump from ^1.1.0 to ^3.0.3 could introduce breaking changes. Please ensure:
- All breaking changes in platform v2.x and v3.x have been addressed
- The new OneDrive actions are compatible with platform v3.x.x
✅ Verification successful
Basic platform features used, compatibility verified
The component only uses stable core features from @pipedream/platform:
- ConfigurationError for error handling
- axios for HTTP requests
These fundamental utilities are unlikely to have breaking changes across major versions.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for any migration guides or breaking changes in the platform package gh api repos/PipedreamHQ/pipedream/releases | jq -r '.[] | select(.tag_name | contains("@pipedream/platform@")) | {tag: .tag_name, body: .body}'Length of output: 146
Script:
#!/bin/bash # Check platform imports and usage in microsoft_onedrive component echo "=== Platform imports ===" rg "@pipedream/platform" components/microsoft_onedrive -A 2 echo -e "\n=== Platform method usage ===" rg "platform\." components/microsoft_onedrive -B 1 -A 2 echo -e "\n=== Check for migration guides ===" fd "MIGRATION|UPGRADING|CHANGELOG" --type fLength of output: 1808
components/microsoft_outlook/package.json (2)
3-3
: Version bump follows semver correctly.The version increase from 1.0.5 to 1.1.0 appropriately reflects the addition of new features mentioned in the PR summary.
15-15
: Consistent platform dependency version.Good to see the same platform version (^3.0.3) being used across both Microsoft components, ensuring consistency in the codebase.
components/microsoft_outlook/actions/add-label-to-email/add-label-to-email.mjs
Show resolved
Hide resolved
components/microsoft_outlook/actions/remove-label-from-email/remove-label-from-email.mjs
Outdated
Show resolved
Hide resolved
components/microsoft_outlook_calendar/actions/get-schedule/get-schedule.mjs
Show resolved
Hide resolved
components/microsoft_outlook_calendar/actions/get-schedule/get-schedule.mjs
Show resolved
Hide resolved
components/microsoft_outlook_calendar/actions/list-events/list-events.mjs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927 lgtm! Ready for QA!
Resolves #15434
Summary by CodeRabbit
Release Notes
New Features
Version Updates
Dependency Updates
@pipedream/platform
dependency across multiple packages.