[BUG] Brevo - Add or Updated Contact failed to update contact

[jcortes]

WHY

Resolves #15034

Summary by CodeRabbit

• New Features

  • Improved handling of contact identifiers in the Brevo integration.
  • Enhanced error messaging for existing contacts during updates or insertions.

• Bug Fixes

  • Updated versioning for the add-or-update-contact action and the @pipedream/brevo package.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	⬜️ Ignored (Inspect)			Dec 25, 2024 3:16pm
pipedream-docs	⬜️ Ignored (Inspect)			Dec 25, 2024 3:16pm
pipedream-docs-redirect-do-not-edit	⬜️ Ignored (Inspect)			Dec 25, 2024 3:16pm

[coderabbitai]

Walkthrough

The pull request focuses on improving the Brevo contact management action by updating the version numbers in both the action file and package configuration. The primary modification is in the contact identifier handling, specifically enhancing the logic for using email as a default identifier and improving error handling when a contact with the same email already exists.

Changes

File	Change Summary
components/brevo/actions/add-or-update-contact/add-or-update-contact.mjs	Updated version to 0.0.4; modified contact identifier logic to default to email
components/brevo/package.json	Updated package version to 0.1.3

Assessment against linked issues

Objective	Addressed	Explanation
Update contact when email exists [#15034]	✅
Handle duplicate email contacts	❓	Requires further verification of actual implementation

Poem

🐰 A Brevo bunny hops with glee,
Updating contacts, version three!
Email now leads the way so bright,
Fixing bugs with coding might!
Hop, hop, hurrah! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e9c364 and f8a86fe.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

• components/brevo/actions/add-or-update-contact/add-or-update-contact.mjs (2 hunks)
• components/brevo/package.json (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• components/brevo/package.json

🔇 Additional comments (2)

components/brevo/actions/add-or-update-contact/add-or-update-contact.mjs (2)

7-7: Version increment looks correct.

Bumping from 0.0.3 to 0.0.4 is consistent with a patch-level change that addresses a reported bug.

---

54-54: Logical change to default the identifier to email is appropriate.

Using providedIdentifier || this.email ensures that if no explicit identifier is supplied, the fallback will be an email-based search and update. Please verify any code paths or tests where providedIdentifier might intentionally be empty, ensuring no unwanted side effects occur if the function defaults to using this.email.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[michelle0927]

LGTM!